Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port deepmedic #94

Closed
wyli opened this issue Feb 19, 2020 · 5 comments
Closed

Port deepmedic #94

wyli opened this issue Feb 19, 2020 · 5 comments

Comments

@wyli
Copy link
Contributor

wyli commented Feb 19, 2020

a subtask of #78, port deepmedic

ref:
https://niftynet.readthedocs.io/en/dev/niftynet.network.deepmedic.html

@wyli wyli added this to the implement reference networks milestone Feb 19, 2020
@tvercaut
Copy link
Member

This might warrant a separate issue but it's probably worth highlignting that the deepmedic paper relies of a post-processing by a dense CRF. The dense CRF is implemented through a permutohedral lattice approach. Although deemedic itself does not rely on backpropagating through the CRF, other papers do (e.g. CRF-RNN) and they also rely on the same permutohedral lattice approach.

As such, it would be good to have a generic permutohedral lattice / CRF-RNN module in MONAI.

A pytorch implementation of the CRF-RNN can be found here but note that the permutohedral lattice does not run on GPU there:
https://github.com/sadeepj/crfasrnn_pytorch/tree/master/crfasrnn
https://github.com/sadeepj/crfasrnn_pytorch/blob/master/crfasrnn/permutohedral.cpp

The corresponding NiftyNet module is here but lacks some GPU ops and cannot back-propagate through features:
https://niftynet.readthedocs.io/en/dev/niftynet.layer.crf.html

An alternative implementation of a GPU-based backpropagatable permutohedral lattice can be found here:
https://github.com/SamuelJoutard/Permutohedral_attention_module

This might also be interesting:
https://github.com/MiguelMonteiro/permutohedral_lattice

@brosscle
Copy link

Hello,
I would like to use and play with the network BLAST (https://github.com/biomedia-mira/blast-ct) which strongly relies on the Deepmedic architecture. Since I discovered MONAI a few days ago, I would like to know if any of you advanced in the portage of Deepmedic in MONAI. I guess I can spend some time and contribute if the portage is not already completed.
Thanks !

@wyli
Copy link
Contributor Author

wyli commented Nov 20, 2020

Hi @brosscle currently there's no plan from the core dev team to port this architectures, please feel free to submit a PR.

for your (or anyone interested in contributing) reference, there are a few examples about using the relevant monai APIs:

also there's a generic contributing guide: https://github.com/Project-MONAI/MONAI/blob/master/CONTRIBUTING.md

@brosscle
Copy link

I will take a look at it, thanks !

@vikashg
Copy link

vikashg commented Jan 4, 2024

closed as merged @charliebudd

@vikashg vikashg closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants