Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazy ignored in SpatialPadd #7315

Closed
KumoLiu opened this issue Dec 13, 2023 · 1 comment
Closed

lazy ignored in SpatialPadd #7315

KumoLiu opened this issue Dec 13, 2023 · 1 comment
Assignees
@KumoLiu
Labels
bug Something isn't working

Comments

@KumoLiu
Copy link
Contributor

KumoLiu commented Dec 13, 2023

Since lazy is always overridden by the parent class, specifying lazy=true in the SpatialPadd constructor does not work. Similar issue in BorderPadd and DivisiblePadd.

MONAI/monai/transforms/croppad/dictionary.py

Line 279 in b1c8b42

Padd.__init__(self, keys, padder=padder, mode=mode, allow_missing_keys=allow_missing_keys)

MONAI/monai/transforms/croppad/dictionary.py

Line 129 in b1c8b42

lazy: bool = False,

Originally posted by @77QiZhang in #7314 (comment)
@KumoLiu KumoLiu self-assigned this Dec 13, 2023
@KumoLiu KumoLiu added the bug Something isn't working label Dec 13, 2023
KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Dec 13, 2023
@KumoLiu
fix Project-MONAI#7315
3611f07 
Signed-off-by: YunLiu <[email protected]>
@KumoLiu KumoLiu mentioned this issue Dec 13, 2023
Merged
7 tasks
KumoLiu added a commit that referenced this issue Dec 18, 2023
@KumoLiu @atbenmurray
Fix lazy ignored in SpatialPadd (#7316)
90d2acb 
Fixes #7314 #7315.


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <[email protected]>
Co-authored-by: Ben Murray <[email protected]>
@vikashg
Copy link

vikashg commented Jan 4, 2024

closing as it is merged @KumoLiu

@vikashg vikashg closed this as completed Jan 4, 2024
marksgraham pushed a commit to marksgraham/MONAI that referenced this issue Jan 30, 2024
@KumoLiu @atbenmurray @marksgraham
Fix lazy ignored in SpatialPadd (Project-MONAI#7316)
0e89c92 
Fixes Project-MONAI#7314 Project-MONAI#7315.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <[email protected]>
Co-authored-by: Ben Murray <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
juampatronics pushed a commit to juampatronics/MONAI that referenced this issue Mar 25, 2024
@KumoLiu @atbenmurray @juampatronics
Fix lazy ignored in SpatialPadd (Project-MONAI#7316)
469db7a 
Fixes Project-MONAI#7314 Project-MONAI#7315.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <[email protected]>
Co-authored-by: Ben Murray <[email protected]>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <[email protected]>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this issue Apr 11, 2024
@KumoLiu @atbenmurray @Yu0610
Fix lazy ignored in SpatialPadd (Project-MONAI#7316)
0163d5b 
Fixes Project-MONAI#7314 Project-MONAI#7315.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <[email protected]>
Co-authored-by: Ben Murray <[email protected]>
Signed-off-by: Yu0610 <[email protected]>
vgrau98 pushed a commit to vgrau98/MONAI that referenced this issue Apr 28, 2024
@KumoLiu @atbenmurray @vgrau98
Fix lazy ignored in SpatialPadd (Project-MONAI#7316)
3c1dea0 
Fixes Project-MONAI#7314 Project-MONAI#7315.


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <[email protected]>
Co-authored-by: Ben Murray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KumoLiu KumoLiu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vikashg @KumoLiu