Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] : 회원 탈퇴 API #70

Closed
wants to merge 3 commits into from
Closed

Conversation

ParkJuhan94
Copy link
Contributor

@ParkJuhan94 ParkJuhan94 commented Mar 6, 2024

close #67

📑 작업 상세 내용

  • 회원 탈퇴 할수있는는 service 메서드와 API 를 개발했습니다.
  • 요청이 성공적으로 처리되었으나, 클라이언트에게 전달할 추가 콘텐츠가 없다는 204
    ResponseEntity.noContent().build(); 를 반환합니다.
  • UserService 의 deleteUser() 에서 exists() 를 합니다. @JwtAuthrizaion 에서 이미 토큰 검사를 하기때문에 필요 없을 수도 있지만 버그 방지차원에서 한 번 더 검사하긴 했습니다.
  • 사용자와 관련된 경매, 댓글, 채팅방, 등등 다 삭제해야 합니다. (보류)

💫 작업 요약

  • 회원 탈퇴

🔍 중점적으로 리뷰 할 부분

  • UserApiController
  • UserService

@ParkJuhan94 ParkJuhan94 requested a review from hyun2371 March 6, 2024 10:32
@ParkJuhan94 ParkJuhan94 self-assigned this Mar 6, 2024
@ParkJuhan94 ParkJuhan94 added the feat New feature or request label Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Test Results

94 tests  +1   94 ✅ +1   26s ⏱️ -1s
26 suites ±0    0 💤 ±0 
26 files   ±0    0 ❌ ±0 

Results for commit a440d54. ± Comparison against base commit 6345e16.

@ParkJuhan94 ParkJuhan94 changed the title [feat] : 사용자 삭제 API [feat] : 사용자 탈퇴 API Mar 6, 2024
@ParkJuhan94 ParkJuhan94 changed the title [feat] : 사용자 탈퇴 API [feat] : 회원 탈퇴 API Mar 6, 2024
@ParkJuhan94 ParkJuhan94 closed this Mar 8, 2024
@ParkJuhan94 ParkJuhan94 deleted the origin/feat/#67/delete-user branch March 8, 2024 08:48
@ParkJuhan94 ParkJuhan94 restored the origin/feat/#67/delete-user branch March 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] : 회원 탈퇴 API
1 participant