Support 1.21.1 #439
Support 1.21.1 #439
Conversation
|
Blocked on #440 |
|
#448 should fix CI |
|
Something else is broken here |
viewer/lib/modelsBuilder.js
Outdated
| @@ -54,6 +54,7 @@ function prepareModel (model, texturesJson) { | |||
| if (face.texture.charAt(0) === '#') { | |||
| face.texture = JSON.parse(JSON.stringify(model.textures[face.texture.substr(1)])) | |||
| } else { | |||
| console.log(texturesJson) | |||
| let name = face.texture | |||
| name = cleanupBlockName(name) | |||
| face.texture = JSON.parse(JSON.stringify(texturesJson[name])) | |||
There was a problem hiding this comment.
Here some name is absent from texturesJson
|
Getting a "null" error on 1.21.1 |
|
Yes please help figure out why |
|
bumping for an update. |
|
I am seeing this failing on this texture "heavy_core". I am just getting familiar with these codebases, but is this because I think we need to modify this conditional logic to account for the |
|
Try it out
…On Wed, Jan 15, 2025, 02:45 Hunter ***@***.***> wrote:
I am seeing this failing on this texture "heavy_core"
<https://github.com/PrismarineJS/minecraft-assets/blob/master/data/1.21.1/blocks_models.json#L21192>
.
I am just getting familiar with these codebases, but is this because all
is not using a hashmark as a link to the textures, so it's trying to lookup
all in the texturesJson instead of replacing all with the texture
heavy_core which is present in texturesJson.
I think we need to modify this conditional logic
<https://github.com/Icyadam14/prismarine-viewer/blob/master/viewer/lib/modelsBuilder.js#L54>
to account for the all possibility (and possibly other) non hash links.
—
Reply to this email directly, view it on GitHub
<#439 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR437TDYGLXZGFIIS4VISD2KW4TJAVCNFSM6AAAAABSSF6CECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJRGQ3DANZZGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
@Icyadam14 please see Icyadam14#1 |
Check if face.texture is a texture reference even in absence of a # prefix.
|
one step forward, one step back 😭 🤣 |
|
@Icyadam14 this should fix CI Icyadam14#2 |
Updated version.js, ci.yml, and README.md.