Breaking change in dependency

[covyy]

As the "minecraft-prackets" module updated from version 1.5 to 1.7 a breaking change was introduced:
getPacket() in /src/instant_connect_proxy.js uses
let packet = packets[ver]?.['from-server']?.[name][0].json where ver is "1.8" (as defined in the verMap)
but version "1.8" was renamed to "1.8.8" in "minecraft-packets", so the packet variable here is always undefined.

https://github.com/PrismarineJS/minecraft-packets/tags

updating verMap to
const verMap = {
'1.8.8': '1.8.8', // used to map to 1.8
'1.8.9': '1.8.8' // used to map to 1.8
}

is a quick fix but maybe other breaking changes where introduced in minecraft-packets?

Alternatively use the outdated minecraft-packets module in package.json:
"minecraft-packets": "^1.5.0" to "minecraft-packets": "1.5.0"

[rom1504]

Let's fix it here

…

On Tue, Dec 24, 2024, 19:05 covy ***@***.***> wrote: As the "minecraft-prackets" module updated from version 1.5 to 1.7 a breaking change was introduced: getPacket() in /src/instant_connect_proxy.js uses let packet = packets[ver]?.['from-server']?.[name][0].json where ver is "1.8" (as defined in the verMap) but version "1.8" was renamed to "1.8.8" in "minecraft-packets", so the packet variable here is always undefined. https://github.com/PrismarineJS/minecraft-packets/tags updating verMap to const verMap = { '1.8.8': '1.8.8', // used to map to 1.8 '1.8.9': '1.8.8' // used to map to 1.8 } is a quick fix but maybe other breaking changes where introduced in minecraft-packets? Alternatively use the outdated minecraft-packets module in package.json: "minecraft-packets": "^1.5.0" to "minecraft-packets": "1.5.0" — Reply to this email directly, view it on GitHub <#42>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437WYL5EYO26UXW2UYHD2HGPABAVCNFSM6AAAAABUFA3AUOVHI2DSMVQWIX3LMV43ASLTON2WKOZSG42TQMJXG44DANA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[covyy]

Here the fix:
#43