Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 1.20.2 #1258

Closed
lastuniverse opened this issue Oct 13, 2023 · 13 comments · Fixed by #1265
Closed

support 1.20.2 #1258

lastuniverse opened this issue Oct 13, 2023 · 13 comments · Fixed by #1265

Comments

@lastuniverse
Copy link

please add support for minecraft 1.20.2

@SilkePilon
Copy link

SilkePilon commented Oct 13, 2023

Support will be added once you implement it and open a Pull Request. (No hard feelings)

@lastuniverse
Copy link
Author

It's a pity. If I succeed, I’ll definitely make a request

@kittenvr
Copy link

upvote

@Arthessia
Copy link

upvote here too :)

@lastuniverse
Copy link
Author

Unfortunately, I won’t be able to deal with this issue for the next two weeks. It's a total mess at work.

@lastuniverse
Copy link
Author

There is still a problem. Before updating node_minecraf_protocol to 1.20.2 you need to wait for the update https://github.com/PrismarineJS/minecraft-data

@lastuniverse
Copy link
Author

I looked at https://github.com/PrismarineJS/minecraft-data .
Basically I'm not able to update minecraft-data without diving deep into it (((

@lastuniverse
Copy link
Author

We are waiting for your reaction here PrismarineJS/minecraft-data#779

@SuchBlue
Copy link

SuchBlue commented Nov 6, 2023

https://github.com/PrismarineJS/minecraft-data now supports 1.20.2

@SuchBlue
Copy link

SuchBlue commented Nov 6, 2023

I have created a pull request #1261

@7yl4r
Copy link

7yl4r commented Nov 18, 2023

an example error when trying to connect:

(base) tylar@laptop:~/repos/mineflayer$ node examples/looker.js localhost 25565
TypeError: Serialization error for login.toServer : Write error for undefined : Cannot read properties of undefined (reading 'length')
    at module.exports.Write.UUID (/home/tylar/repos/mineflayer/node_modules/minecraft-protocol/src/datatypes/compiler-minecraft.js:50:25)
    at Object.packet_login_start (eval at compile (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:258:12), <anonymous>:708:26)
    at eval (eval at compile (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:258:12), <anonymous>:754:62)
    at packet (eval at compile (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:258:12), <anonymous>:760:9)
    at CompiledProtodef.write (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:76:12)
    at e.message (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:102:25)
    at tryCatch (/home/tylar/repos/mineflayer/node_modules/protodef/src/utils.js:50:16)
    at CompiledProtodef.createPacketBuffer (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:102:5)
    at Serializer.createPacketBuffer (/home/tylar/repos/mineflayer/node_modules/protodef/src/serializer.js:12:23)
    at Serializer._transform (/home/tylar/repos/mineflayer/node_modules/protodef/src/serializer.js:18:18) {
  field: 'login.toServer'
}

The 1.20.1 changelog mentions "NETWORK PROTOCOL" changes.
Without more details on that I don't know how to proceed.

@rom1504
Copy link
Member

rom1504 commented Nov 18, 2023 via email

@Parker2991
Copy link

also happens in node-minecraft-protocol but something about the uuid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants