Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store block references in targets list #34

Open
TheDudeFromCI opened this issue Nov 8, 2020 · 4 comments
Open

Don't store block references in targets list #34

TheDudeFromCI opened this issue Nov 8, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@TheDudeFromCI
Copy link
Member

Blocks are not permanent references in Mineflayer. Each time a block is updated, it created a new block object. So storing blocks as direct references in the target list leads to only storing how they were before they were targeted. Things like checking if the block has been changed or destroyed no longer works.

@TheDudeFromCI TheDudeFromCI added the bug Something isn't working label Nov 8, 2020
@MichaelLykkeStrand
Copy link

Any ETA on a fix? :)

@TheDudeFromCI
Copy link
Member Author

@MichaelLykkeStrand Should be fixed when #42 is finished,

@ychunwei
Copy link

Hi, just checking in to see if there are workarounds for this?

This is because I want to have two or more bots interact with each other and was wondering what happens when the block is mined by a bot before another one gets there.

Is there like a timeout function that just makes the bot move on to the next block?

Also just curious when this bug could be resolved.

Keep up the good work!

@TheDudeFromCI
Copy link
Member Author

Hi, just checking in to see if there are workarounds for this?

This is because I want to have two or more bots interact with each other and was wondering what happens when the block is mined by a bot before another one gets there.

Is there like a timeout function that just makes the bot move on to the next block?

Also just curious when this bug could be resolved.

Keep up the good work!

At the moment, the bot will get stuck when trying to mine a block that is already broken and will stand still forever. Sadly, there are not really any current workarounds at the moment without modifying the plugin directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants