Skip to content
This repository has been archived by the owner on Jan 24, 2018. It is now read-only.

Skrollr and Bootstrap Scrollspy #235

Closed
SILENTRUN opened this issue Jun 2, 2013 · 7 comments
Closed

Skrollr and Bootstrap Scrollspy #235

SILENTRUN opened this issue Jun 2, 2013 · 7 comments

Comments

@SILENTRUN
Copy link

Anyway to get skrollr and bootstrap scroll spy to play nice together in Firefox and IE 9/10 (working in Chrome)?

I'm guessing this has to do with the way skrollr calculates page height and then Bootstrap scroll spy is trying to do the same thing.

Do I need to have Bootstrap scrollspy calculate page height after skrollr is finished? If so, how would I go about doing that?

Any help is greatly appreciated.

@Prinzhorn
Copy link
Owner

Could you set up an example I can use for debugging? thanks

@claudchan
Copy link

Hi, I am having same issue with bootstrap scroll spy.
Here my test site: http://goo.gl/jj61DV

EDIT:
The top navbar menus didn't active when scroll.

@Prinzhorn
Copy link
Owner

Your content is positioned fixed. There's absolutely no way for Bootstrap or anyone to know, when you want the navigation item to become active.

ScrollSpy also has data-offset, which an be used similar to skrollr-menu's data-menu-top http://getbootstrap.com/javascript/#scrollspy-usage

@claudchan
Copy link

Thanks, I added data-offset accordingly. Not working.

EDIT:
I think I will be use alternative way.
Hope that skrollr-menu Prinzhorn/skrollr-menu#15 implement active link on scroll.
Can't wait to have this feature.

Thanks!

@Prinzhorn
Copy link
Owner

I've just opened your page again and it's working in Firefox and Chrome. Does it work for you as well?

@claudchan
Copy link

Actually, the one working that you notice was I use other method (using data.curTop) to trigger it active. I had reverted back to previous now (using bootstrap ScrollSpy). If you want to check it out.
Test site: http://goo.gl/jj61DV

Hope that skrollr-menu Prinzhorn/skrollr-menu#15 implement active link on scroll so that I no need to depend on other pluggins.

@Prinzhorn
Copy link
Owner

I took a look at it, but I don't have time to get deeper into scrollspy. Don't expect Prinzhorn/skrollr-menu#15 to be implemented any time soon. It needs some major changes to skrollr itself as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants