-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extraneous DeleteAthenaArray() calls #559
Comments
I think that would be fine and would make the code more internally consistent. |
Do we have a test to check memory? I do remember I had some memory issues
with AMR without some of the DeleteAthenaArray functions.
…On Tue, Jan 30, 2024 at 3:15 PM Chris White ***@***.***> wrote:
I think that would be fine and would make the code more internally
consistent.
—
Reply to this email directly, view it on GitHub
<#559 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCWEJ725IOI3VEDHUV5BITYRFIHLAVCNFSM6AAAAABCRY3A5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXHAYTQMZQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Best,
Yan-Fei Jiang
Associate Research Scientist,
Flatiron Institute,
160 Fifth Avenue
New York, NY 10010
|
nothing explicitly targeting memory usage or leaks in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After #558, I glanced at the code and noticed 166 calls to
DeleteAthenaArray()
, and I think they were all added in the radiation merge last year #492, except for 6x inpgen/hgb.cpp
andpgen/jgg.cpp
. Missed this in reviewing the pull request.Any issue with removing all of them @yanfeij @c-white @tomidakn ?
The text was updated successfully, but these errors were encountered: