-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove caption and title tags of the images #179
Conversation
@Uhor You need to remove one error from 1.7.8 phpstan config, then all good :-)
|
Should I change the version? |
@Uhor Not needed, we can bump it later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Uhor ,
Generated multiple sitemaps with different languages.
The tags <image:caption>
, <image:geo_location>
, <image:title>
and <image:license>
are not displayed anymore and I found no other issue.
LGTM ✅
Good job everyone! @Uhor Adrian, you can bump the version to 4.5.0 and we can do a release. ;-) |
It's already merged and didn't bump the version. It's okay? |
Yes, PRs to develop branch don't have to bump a version, if they are not adding some upgrade scripts. You can do it in a separate PR. :-) |
<image:caption>, <image:geo_location>, <image:title>, <image:license>
, so we can delete that part from the code, making sitemap file lighter (good for big stores).Links: