From b6fd14d137ac5af7ecc60ee0feda5ec9eb5c7b62 Mon Sep 17 00:00:00 2001
From: antyadev <antyadev@gmail.com>
Date: Thu, 12 Jan 2023 11:45:53 +0200
Subject: [PATCH] fixed tests

---
 .../Plugins/PluginTests.fs                    | 88 +------------------
 .../Reporting/ReportingSinkTests.fs           |  1 +
 .../ScenarioTests/WarmUpTests.fs              |  2 +-
 3 files changed, 3 insertions(+), 88 deletions(-)

diff --git a/tests/NBomber.IntegrationTests/Plugins/PluginTests.fs b/tests/NBomber.IntegrationTests/Plugins/PluginTests.fs
index 4fd6c499..c9aa8e51 100644
--- a/tests/NBomber.IntegrationTests/Plugins/PluginTests.fs
+++ b/tests/NBomber.IntegrationTests/Plugins/PluginTests.fs
@@ -62,37 +62,7 @@ let ``WorkerPlugin Init, Start, Stop should be invoked once for Warmup and once
     test <@ List.rev invocationOrder = ["init"; "start"; "stop"; "start"; "stop"; "get_stats"; "get_hints"; "dispose"] @>
 
 [<Fact>]
-let ``StartTest should be invoked once`` () =
-
-    let scenarios = PluginTestHelper.createScenarios()
-    let mutable pluginStartTestInvokedCounter = 0
-
-    let plugin = {
-        new IWorkerPlugin with
-            member _.PluginName = "TestPlugin"
-            member _.Init(_, _) = Task.CompletedTask
-
-            member _.Start() =
-                pluginStartTestInvokedCounter <- pluginStartTestInvokedCounter + 1
-                Task.CompletedTask
-
-            member _.GetHints() = Array.empty
-            member _.GetStats(_) = Task.FromResult(new DataSet())
-            member _.Stop() = Task.CompletedTask
-            member _.Dispose() = ()
-    }
-
-    NBomberRunner.registerScenarios scenarios
-    |> NBomberRunner.withWorkerPlugins [plugin]
-    |> NBomberRunner.run
-    |> Result.mapError(fun x -> failwith x)
-    |> ignore
-
-    test <@ pluginStartTestInvokedCounter = 1 @>
-
-
-[<Fact>]
-let ``StartTest should be invoked with infra config`` () =
+let ``Init should be invoked with infra config`` () =
 
     let scenarios = PluginTestHelper.createScenarios()
     let mutable pluginConfig = Unchecked.defaultof<_>
@@ -123,62 +93,6 @@ let ``StartTest should be invoked with infra config`` () =
 
     test <@ isNull serilogConfig = false @>
 
-[<Fact>]
-let ``GetStats should be invoked only one time when final stats fetching`` () =
-
-    let scenarios = PluginTestHelper.createScenarios()
-    let mutable pluginGetStatsInvokedCounter = 0
-
-    let plugin = {
-        new IWorkerPlugin with
-            member _.PluginName = "TestPlugin"
-            member _.Init(_, _) = Task.CompletedTask
-            member _.Start() = Task.CompletedTask
-
-            member _.GetStats(stats) =
-                pluginGetStatsInvokedCounter <- pluginGetStatsInvokedCounter + 1
-                Task.FromResult(new DataSet())
-
-            member _.GetHints() = Array.empty
-            member _.Stop() = Task.CompletedTask
-            member _.Dispose() = ()
-    }
-
-    NBomberRunner.registerScenarios scenarios
-    |> NBomberRunner.withWorkerPlugins [plugin]
-    |> NBomberRunner.run
-    |> Result.mapError(fun x -> failwith x)
-    |> ignore
-
-    test <@ pluginGetStatsInvokedCounter = 1 @>
-
-[<Fact>]
-let ``StopTest should be invoked once`` () =
-
-    let scenarios = PluginTestHelper.createScenarios()
-    let mutable pluginFinishTestInvokedCounter = 0
-
-    let plugin = {
-        new IWorkerPlugin with
-            member _.PluginName = "TestPlugin"
-            member _.Init(_, _) = Task.CompletedTask
-            member _.Start() = Task.CompletedTask
-            member _.GetStats(_) = Task.FromResult(new DataSet())
-            member _.GetHints() = Array.empty
-            member _.Stop() =
-                pluginFinishTestInvokedCounter <- pluginFinishTestInvokedCounter + 1
-                Task.CompletedTask
-            member _.Dispose() = ()
-    }
-
-    NBomberRunner.registerScenarios scenarios
-    |> NBomberRunner.withWorkerPlugins [plugin]
-    |> NBomberRunner.run
-    |> Result.mapError(fun x -> failwith x)
-    |> ignore
-
-    test <@ pluginFinishTestInvokedCounter = 1 @>
-
 [<Fact>]
 let ``PluginStats should return empty data set in case of execution timeout`` () =
     let inMemorySink = new InMemorySink()
diff --git a/tests/NBomber.IntegrationTests/Reporting/ReportingSinkTests.fs b/tests/NBomber.IntegrationTests/Reporting/ReportingSinkTests.fs
index 21fc0e5f..b56601c6 100644
--- a/tests/NBomber.IntegrationTests/Reporting/ReportingSinkTests.fs
+++ b/tests/NBomber.IntegrationTests/Reporting/ReportingSinkTests.fs
@@ -324,5 +324,6 @@ let ``ReportingSink Init, Start, Stop should be invoked once for Warmup and once
     |> Result.mapError failwith
     |> ignore
 
+    test <@ saveRealtimeStatsCounter > 0 @>
     test <@ List.rev invocationOrder = ["init"; "start"; "stop"; "start"; "stop"; "save_final_stats"; "dispose"] @>
 
diff --git a/tests/NBomber.IntegrationTests/ScenarioTests/WarmUpTests.fs b/tests/NBomber.IntegrationTests/ScenarioTests/WarmUpTests.fs
index f6fb62e4..45adb5d9 100644
--- a/tests/NBomber.IntegrationTests/ScenarioTests/WarmUpTests.fs
+++ b/tests/NBomber.IntegrationTests/ScenarioTests/WarmUpTests.fs
@@ -32,7 +32,7 @@ let ``Warmup should have no effect on stats`` () =
 
         return Response.ok()
     })
-    |> Scenario.withWarmUpDuration(seconds 3)
+    |> Scenario.withWarmUpDuration(seconds 1)
     |> Scenario.withLoadSimulations [KeepConstant(copies = 1, during = seconds 1)]
     |> NBomberRunner.registerScenario
     |> NBomberRunner.withoutReports