Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell Intellisense dropdown in Microsoft Terminal #1362

Closed
Ayanmullick opened this issue Feb 20, 2020 · 10 comments
Closed

PowerShell Intellisense dropdown in Microsoft Terminal #1362

Ayanmullick opened this issue Feb 20, 2020 · 10 comments
Labels

Comments

@Ayanmullick
Copy link

Ayanmullick commented Feb 20, 2020

Description of the new feature/enhancement

Could an SQLCLI-like terminal intellisense dropdown be enabled for PowerShell in the new Microsoft Terminal thru PSReadline?

Image of Yaktocat

Proposed technical implementation details (optional)

Working on the terminal with PowerShell 7 could become more convenient if one was able to see all the potential matches for one's cmdlets and parameter values in a dropdown right in the terminal.

image

Creating issue as discussed during community call.
PowerShell/PowerShell-RFC#242 (comment)

@Ayanmullick Ayanmullick added the Issue-Enhancement It's a feature request. label Feb 20, 2020
@ghost ghost added the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Feb 20, 2020
@lzybkr
Copy link
Member

lzybkr commented Feb 20, 2020

See microsoft/terminal#3121

@Ayanmullick
Copy link
Author

Ayanmullick commented Feb 20, 2020

See microsoft/terminal#3121

@DHowett-MSFT , a member of the Microsoft Terminal product group, had explained that this needs to be enabled at the PowerShell level by the PowerShell team and not at the Terminal level.

@lzybkr
Copy link
Member

lzybkr commented Feb 20, 2020

@Ayanmullick - right - the shell must do something to invoke some UI.

The UI could be implemented 100% by the shell - PowerTab was popular for an experience close to what you're suggesting.

Alternatively, the terminal could provide a UI that the shell invokes which is what I understand something some terminals provide or are considering providing.

@Ayanmullick
Copy link
Author

@lzybkr , Right and PowerTab errors out on VSC and on MSTerminal.

@daxian-dbw daxian-dbw removed the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Feb 27, 2020
@Ayanmullick
Copy link
Author

Even AzCLI has an interactive mode that works on the cloudshell too.

@lzybkr
Copy link
Member

lzybkr commented Mar 19, 2020

@Ayanmullick - have you tried MenuComplete? It is a different experience than the examples you've raised, but it is an interactive experience showing help and filtering.

The default key binding Ctrl+Spacebar doesn't work in Windows Terminal, but you can bind it to another key.

@Ayanmullick
Copy link
Author

Ayanmullick commented Mar 10, 2021

@lzybkr , I tried it. I prefer the more fluid experiences in the screenshot above to the Ctrl+Spacebar experience. However, since most of my work is with the Az modules the Az predictor somewhat fills that gap. I wish there was a predictor for the MSGraph modules too.

@StevenBucher98
Copy link
Collaborator

A lot of this is addressed with the latest preview of Windows Terminal, https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-19-release/

@Ayanmullick
Copy link
Author

Yes, the Suggestions UI and Shell Completion Menu look promising. That's what I was looking for. Does it work with Azure resources, too, like in the screen clip above, @StevenBucher98?

@StevenBucher98
Copy link
Collaborator

I do not believe so, I think it just uses tab completion for the suggestions and not sure if Az does tab completions for that.

cc @dcaro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants