Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find module 'rrweb/src/types' or its corresponding type declarations. #437

Closed
florianherrengt opened this issue Aug 18, 2022 · 7 comments

Comments

@florianherrengt
Copy link

I think it should be part of the dependencies instead of dev dependencies.

https://github.com/PostHog/posthog-js/blob/master/package.json#L66

@pauldambra
Copy link
Member

sorry we missed this!
i'm going to assume this was fixed already or more people would have reported it 🙈

@kyleatpanoptyc
Copy link

@pauldambra it wasn't fixed: https://github.com/PostHog/posthog-js/blob/main/package.json#L61-L63

Would you accept a PR that moves these dependencies?

@pauldambra
Copy link
Member

👋 hey @kyleatpanoptyc

they're not (or shouldn't be) runtime dependencies - all the rrweb code is bundled into recorder.ts

if this is causing problems in some way we'd need to fix something, not just move the dependencies

@kyleatpanoptyc
Copy link

Got it. Yeah, we're getting the error described in #1532 and I wasn't sure if this was the cause or not.

@nikolaihe
Copy link

nikolaihe commented Nov 21, 2024

Is there a solution for this yet? I am still getting this error. I am not getting the error in oder versions (e.g. 1.160.1)

@da201501245
Copy link

I am also getting this error please help!!

@da201501245
Copy link

da201501245 commented Nov 22, 2024

👋 hey @kyleatpanoptyc

they're not (or shouldn't be) runtime dependencies - all the rrweb code is bundled into recorder.ts

if this is causing problems in some way we'd need to fix something, not just move the dependencies
@pauldambra we are not able use this package in angular because of this error please fix it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants