From 695166edeb9ba613fc6ce28f3f7ec3ff066456aa Mon Sep 17 00:00:00 2001 From: stevenportkey Date: Tue, 10 Sep 2024 11:48:59 +0800 Subject: [PATCH 1/2] fix(HML-01): remove saltLen which is not required --- circuits/idHashMapping.circom | 1 - tests/idHashMapping.test.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/circuits/idHashMapping.circom b/circuits/idHashMapping.circom index b44b4a9..caa6d4f 100644 --- a/circuits/idHashMapping.circom +++ b/circuits/idHashMapping.circom @@ -7,7 +7,6 @@ template IdHashMapping(maxSubLen, maxSaltLen){ signal input sub[maxSubLen]; signal input subLen; signal input salt[maxSaltLen]; - signal input saltLen; component poseidonHasher = IdHashPoseidon(maxSubLen, maxSaltLen); poseidonHasher.sub <== sub; diff --git a/tests/idHashMapping.test.ts b/tests/idHashMapping.test.ts index e9d89ca..5f816b5 100644 --- a/tests/idHashMapping.test.ts +++ b/tests/idHashMapping.test.ts @@ -52,7 +52,6 @@ describe("Id Hash Mapping Test", () => { ), subLen: 21, salt: Array.from(hexToBytes("a677999396dc49a28ad6c9c242719bb3"), (b) => b), - saltLen: 16 }; // will be packed into [13846356912322354, 85189581377597132177622858375434543549286969422497087616931493135530328064, 0,0,0,0,0,0,0] From 0a544a7b1fc3cfa8266e463e7706a150439b0644 Mon Sep 17 00:00:00 2001 From: stevenportkey Date: Tue, 10 Sep 2024 11:54:48 +0800 Subject: [PATCH 2/2] fix(LPW-01): remove unnecessary variables --- circuits/zkLogin.circom | 5 ----- circuits/zkLoginSha256.circom | 5 ----- 2 files changed, 10 deletions(-) diff --git a/circuits/zkLogin.circom b/circuits/zkLogin.circom index defba97..2259713 100644 --- a/circuits/zkLogin.circom +++ b/circuits/zkLogin.circom @@ -12,11 +12,6 @@ template ZkLogin(maxHeaderLen, maxPaddedUnsignedJWTLen){ var maxWhiteSpaceLen = 2; // actually we don't need this var maxSubClaimLen = maxSubNameLen + maxSubValueLen + maxWhiteSpaceLen; // TODO: Check if this calculation is correct - var maxExpLen = 10; - var maxExpNameLen = 5; - var maxExpValueLen = maxExpLen; - var maxExpClaimLen = maxExpNameLen + maxExpValueLen + maxWhiteSpaceLen; // TODO: Check if this calculation is correct - var maxNonceLen = 64; var maxNonceNameLen = 7; var maxNonceValueLen = maxNonceLen + 2; // 2 for double quotes diff --git a/circuits/zkLoginSha256.circom b/circuits/zkLoginSha256.circom index f166e26..4d47ac3 100644 --- a/circuits/zkLoginSha256.circom +++ b/circuits/zkLoginSha256.circom @@ -12,11 +12,6 @@ template ZkLoginSha256(maxHeaderLen, maxPaddedUnsignedJWTLen){ var maxWhiteSpaceLen = 2; // actually we don't need this var maxSubClaimLen = maxSubNameLen + maxSubValueLen + maxWhiteSpaceLen; // TODO: Check if this calculation is correct - var maxExpLen = 10; - var maxExpNameLen = 5; - var maxExpValueLen = maxExpLen; - var maxExpClaimLen = maxExpNameLen + maxExpValueLen + maxWhiteSpaceLen; // TODO: Check if this calculation is correct - var maxNonceLen = 64; var maxNonceNameLen = 7; var maxNonceValueLen = maxNonceLen + 2; // 2 for double quotes