Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add checks to check if asset/account exists #32

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

sansan
Copy link

@sansan sansan commented Aug 2, 2024

Description

adds additional validation checks:

  • checks if sending CA exists
  • checks if receiving CA exists
  • checks if provided confidential accounts exist

JIRA Link

https://polymesh.atlassian.net/browse/DA-1233

Checklist

  • Updated the Readme.md (if required) ?

@sansan sansan requested a review from a team as a code owner August 2, 2024 14:28
@sansan sansan changed the base branch from master to alpha August 2, 2024 14:28
Copy link
Collaborator

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think data is something we should try to add in when we can. I find it helpful for debugging. Tests don't need to be updated, the code and message assertions should be enough.

src/api/procedures/moveFunds.ts Show resolved Hide resolved
src/api/procedures/moveFunds.ts Outdated Show resolved Hide resolved
@sansan sansan changed the title Feat/da 1233 add checks feat: 🎸 add checks to check if asset/account exists Aug 4, 2024
Copy link

sonarqubecloud bot commented Aug 5, 2024

@sansan sansan merged commit 56b663b into alpha Aug 6, 2024
11 checks passed
@sansan sansan deleted the feat/DA-1233-add-checks branch August 6, 2024 11:47
@polymath-eric
Copy link
Collaborator

🎉 This PR is included in version 2.0.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@polymath-eric
Copy link
Collaborator

🎉 This PR is included in version 2.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@polymath-eric
Copy link
Collaborator

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants