Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Get rid of --text-primary-color which is deprecated #69

Open
mercmobily opened this issue May 5, 2016 · 2 comments
Open

Get rid of --text-primary-color which is deprecated #69

mercmobily opened this issue May 5, 2016 · 2 comments

Comments

@mercmobily
Copy link

In this file you are still using --text-primary-color:

color: var(--text-primary-color);

This stile is now deprecated:

https://github.com/PolymerElements/paper-styles/blob/master/default-theme.html#L64-L68

@keanulee
Copy link
Contributor

Should replace it with --dark-theme-text-color to keep the default value consistent. This would be breaking API change for paper-fab though (since --text-primary-color will be no longer available), so best to leave it until the next breaking release.

@mercmobily
Copy link
Author

mercmobily commented May 14, 2016

I frankly think that using --dark-theme-text-color has the potential of not being so good, since it feels to me like it's only a variable meant to facilitate the setting of the "real" paper variables ( --primary-color --light-primary-color, --dark-primary-color, etc). The only other element using a --dark-theme variable is the paper-toolbar.
In my own CSS I don't even set the --dark-theme or light-theme variables.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants