Skip to content
This repository has been archived by the owner on Dec 28, 2024. It is now read-only.

Events not documented #29

Open
arthurevans opened this issue Jun 3, 2015 · 9 comments
Open

Events not documented #29

arthurevans opened this issue Jun 3, 2015 · 9 comments

Comments

@arthurevans
Copy link
Contributor

iron-select, iron-deselect, iron-activate should be documented, but aren't.

@grokys
Copy link

grokys commented Jul 2, 2015

+1 - Please document, I'm lost here!

@01es
Copy link

01es commented Jul 7, 2015

+1

I'm using iron-deselect and iron-activate in the context of the iron-selector element, which works really well in conjunction with attribute attr-for-selected.

Are these events intended to be used with other elements? Some use cases would be of great value.

Trakkasure pushed a commit to Trakkasure/iron-selector that referenced this issue Jul 25, 2015
cdata added a commit that referenced this issue Sep 4, 2015
Added event documentation. Fixes request in #29.
@notwaldorf
Copy link
Contributor

Anyone who does this gets free emoji from me!

@notwaldorf
Copy link
Contributor

Preview: 🌵 🍰 📲

@arthurevans
Copy link
Contributor Author

Currently, these are documented in the behavior, but the descriptions aren't showing up in the element.

According to PolymerElements/iron-doc-viewer#74
this was a hydrolysis bug that @garlicnation fixed. But it doesn't appear to be working with the current version of the catalog. Halp halp.

@bicknellr
Copy link
Contributor

Does hydrolysis need a release to be cut before it's used by the catalog? The fix seems to be in master as of a couple weeks ago (here) but there hasn't been a release since November.

@garlicnation
Copy link
Contributor

@bicknellr Nice catch! I'll do a release of hydrolysis ASAP and this will get fixed.

@arthurevans
Copy link
Contributor Author

I was looking at this again. For some reason the catalog appears to have regressed on this front. Also, the event doc doesn't describe the event properties. I'll submit a PR for that.

@bicknellr
Copy link
Contributor

Any news here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants