Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IronMenuBehavior prevents all keyboard events from bubbling #82

Open
lghall opened this issue Oct 17, 2016 · 1 comment · May be fixed by #83
Open

IronMenuBehavior prevents all keyboard events from bubbling #82

lghall opened this issue Oct 17, 2016 · 1 comment · May be fixed by #83
Labels
source: hooli

Comments

@lghall
Copy link

lghall commented Oct 17, 2016

Description

IronMenuBehavior's _onKeyDown calls stopPropagation() on every keydown event, instead of just stopping the propagation of key combos which you can use to select items. This prevents global event handlers from triggering on common shortcuts (e.g. Ctrl+C, Ctrl+Z) when focus is in a menu.

Browsers Affected

All
@lghall lghall linked a pull request Nov 2, 2016 that will close this issue
Open
bicknellr added a commit that referenced this issue Nov 10, 2016
@bicknellr
Fixes #82: Adds the disable-keyboard-search attribute.
4c1fee6
@Chali-Anne
Copy link

+1 I tried to bind ctrl+s to a page with a paper-listbox and it does not bubble when said element is focused.

bicknellr added a commit that referenced this issue Mar 31, 2017
@bicknellr
Fixes #82: Adds the disable-keyboard-search attribute.
09511dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
source: hooli
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bug where iron-menu-behavior swallowed all keydown lghall/iron-menu-behavior
3 participants
@bicknellr @Chali-Anne @lghall