-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Polly v8 Please #8
Comments
hello, is there any progress ? |
+1, AFAIK it's backwards compatible, so this is likely a metadata-only update. would very much like Polly 8 to be supported. |
I echo the above! |
@jjxtra / @joelhulen would either of you be able to help out with this? This seems like it mainly requires re-generating the nuget to support 8.0.0. |
Have sent a commit to master. |
Can we also target earlier versions of .Net by any chance? |
Especially since .net 6 is the one with longterm support |
Done. The nuget itself is netstandard2.0. |
thank you @jjxtra . Let us know once publlished and we'll test uptake. Thank u so much |
@reisenberger Can you publish nuget 0.3.0? |
Hasnt been published yet. Can anyone else publish or has access to publish? @jjxtra cc @reisenberger |
I cannot |
Ah okay. Anyone other contributor has access to? or just @reisenberger ? |
We encountering another issue that will be resolved by this deployment:
|
Have uploaded a custom nuget of this as DigitalRuby.Polly.Contrib.DuplicateRequestCollapser. If @reisenberger wants to respond, we can try to fix the build and get this deployed with the original Polly.Contrib.DuplicateRequestCollapser package name. |
@joelhulen, would you be able to publish the latest change making DuplicateRequestCollapser compatible with Polly v8 to NuGet? We see you were the last to publish a release of this project. My company is still using this and find it quite useful. Thank you in advance. |
I've updated this to use the V8 syntax if someone would like to review / publish a new nuget package. #9. |
@Kirtlander, sorry, I just saw your message from January. I get tons of GitHub emails every day. I'll try and publish now. |
@nzdev and @Kirtlander, the I've merged the PR, but the build is currently failing with |
Hi @nzdev and @Kirtlander, any update on this? |
#10 Fixed the build @joelhulen |
@joelhulen any chance to release this anytime soon? |
+1 would be great to have a release |
The NuGet package prevents this package from restoring with Polly v8, could support for Polly v8 please be added? Thank you.
The text was updated successfully, but these errors were encountered: