Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Polly v8 Please #8

Open
taspeotis opened this issue Oct 6, 2023 · 24 comments
Open

Support for Polly v8 Please #8

taspeotis opened this issue Oct 6, 2023 · 24 comments

Comments

@taspeotis
Copy link

The NuGet package prevents this package from restoring with Polly v8, could support for Polly v8 please be added? Thank you.

image

@mzcatcher
Copy link

hello, is there any progress ?

@cmeeren
Copy link

cmeeren commented Nov 24, 2023

+1, AFAIK it's backwards compatible, so this is likely a metadata-only update. would very much like Polly 8 to be supported.

@realgio95
Copy link

realgio95 commented Dec 1, 2023

I echo the above!

@ernesto1596
Copy link

@jjxtra / @joelhulen would either of you be able to help out with this? This seems like it mainly requires re-generating the nuget to support 8.0.0.

@jjxtra
Copy link
Contributor

jjxtra commented Dec 1, 2023

Have sent a commit to master.

@realgio95
Copy link

Can we also target earlier versions of .Net by any chance?

@realgio95
Copy link

Especially since .net 6 is the one with longterm support

@jjxtra
Copy link
Contributor

jjxtra commented Dec 1, 2023

Done. The nuget itself is netstandard2.0.

@realgio95
Copy link

thank you @jjxtra . Let us know once publlished and we'll test uptake. Thank u so much

@jjxtra
Copy link
Contributor

jjxtra commented Dec 1, 2023

@reisenberger Can you publish nuget 0.3.0?

@realgio95
Copy link

Hasnt been published yet. Can anyone else publish or has access to publish? @jjxtra cc @reisenberger

@jjxtra
Copy link
Contributor

jjxtra commented Dec 4, 2023

I cannot

@realgio95
Copy link

Ah okay. Anyone other contributor has access to? or just @reisenberger ?

@realgio95
Copy link

We encountering another issue that will be resolved by this deployment:

  • there is no version of Polly.RateLimiting <8.0.0
  • Polly.RateLimiting brings dependency on Polly.Core 8
  • Polly.Core 8 has some of the objects of Polly 7, causing conflicts :(

@jjxtra
Copy link
Contributor

jjxtra commented Dec 21, 2023

Have uploaded a custom nuget of this as DigitalRuby.Polly.Contrib.DuplicateRequestCollapser.

If @reisenberger wants to respond, we can try to fix the build and get this deployed with the original Polly.Contrib.DuplicateRequestCollapser package name.

@Kirtlander
Copy link

@joelhulen, would you be able to publish the latest change making DuplicateRequestCollapser compatible with Polly v8 to NuGet? We see you were the last to publish a release of this project. My company is still using this and find it quite useful. Thank you in advance.

@nzdev
Copy link

nzdev commented Mar 7, 2024

I've updated this to use the V8 syntax if someone would like to review / publish a new nuget package. #9.

@joelhulen
Copy link
Member

@Kirtlander, sorry, I just saw your message from January. I get tons of GitHub emails every day. I'll try and publish now.

@joelhulen
Copy link
Member

@nzdev and @Kirtlander, the I've merged the PR, but the build is currently failing with Failed to install addin 'Cake.FileHelpers'.: https://ci.appveyor.com/project/Polly-Contrib/polly-contrib-duplicaterequestcollapser/builds/49352636. If one of you can address this and get a successful build, I'll publish the NuGet package.

@howej
Copy link

howej commented Mar 29, 2024

Hi @nzdev and @Kirtlander, any update on this?

@nzdev
Copy link

nzdev commented Apr 4, 2024

#10 Fixed the build @joelhulen

@AndreaCuneo
Copy link

@joelhulen any chance to release this anytime soon?

@akashsinghal
Copy link

+1 would be great to have a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests