New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BK GrabbieLib improvements #97

Open

Sunderlandkyl opened this issue Sep 21, 2017 · 1 comment

Milestone

Release Plus-Future

Contributor

Sunderlandkyl commented Sep 21, 2017 •

edited

Loading

BK's GrabbieLib needs some fixes and improvements:

The TcpClient::Write(buffer, size) method in BK returns (size+2) if the operation is successful. It should return (size) instead. See usage in vtkBkProFocusOemVideoSource::InternalUpdate().
Improve CMake files: it should properly export all library targets

Migrated from https://app.assembla.com/spaces/plus/tickets/722/details

Sunderlandkyl added this to the Release Plus-Future milestone

Contributor Author

Sunderlandkyl commented Sep 21, 2017

2013-04-11 18:32
Andras Lasso
(In plus:2686) re #722: Added comment explaining why we add +2 to the expected return value of OemClient->Write

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment