Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BK 8862/8863 probes #115

Open
Sunderlandkyl opened this issue Sep 21, 2017 · 1 comment
Open

Add support for BK 8862/8863 probes #115

Sunderlandkyl opened this issue Sep 21, 2017 · 1 comment

Comments

@Sunderlandkyl
Copy link
Contributor

We have used the attached patch to add support for several additional BK probes (so far used with 8862 probe to acquire RF data during one neurosurgery case).
This issue is to request review and advice. In particular there are two points which would break support for the prostate probe:

L44: there is only one channel available (also for 8863 and 8820e probes)

  • Should I add a configuration option to make this check contingent on a configured number of channels?

L57: the modelID field != 0 for at least the 8862

  • Not sure what to do about this.

Thank you.

Migrated from https://app.assembla.com/spaces/plus/tickets/854/details

@Sunderlandkyl Sunderlandkyl added this to the Release Plus-Future milestone Sep 21, 2017
@Sunderlandkyl
Copy link
Contributor Author

2014-01-21 12:31
Isaiah Norton
8862-diff.txt

2014-01-21 15:48
Andras Lasso
Any solution that is backward compatible should be fine.
@rankin, could you please review and integrate the proposed changes?

2014-01-21 16:11
Adam Rankin
It seems fine. Does is still work for the existing setups is the real question.

2014-01-21 16:21
Isaiah Norton
Well I think we are the only existing BK setup (?). I will see if I can get access to the other probe and make this compatible before committing. Thanks.

2014-03-05 15:23
Adam Rankin
@ihnorton Any luck? The change didn't seem very risky. If you don't think you'll have a chance to test it soon I'll move this to PLUS future for further testing.

2014-03-06 14:17
Isaiah Norton
That's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant