Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PhidgetSpatial per-tool parameter settings to the tool elements #109

Open
Sunderlandkyl opened this issue Sep 21, 2017 · 2 comments
Open

Comments

@Sunderlandkyl
Copy link
Contributor

Move attributes such as TiltSensorWestAxisIndex, AhrsAlgorithm, AhrsAlgorithmGain, etc. in the tool elements.

To manage deprecation: PLUS_ENABLE_DEPRECATED_API controls supporting of deprecated config file or algo interface. Remove in next major version (or after 6 months). Add date of deprecation. Log warning when deprecated API is used and explain how to migrate to the supported version.

<Device
Type=”PhidgetSpatial”
Id=”TrackerDevice”
AcquisitionRate=”125”
LocalTimeOffsetSec=”0.0”>

<DataSources>
<DataSource Type=”Tool” Id=”Accelerometer” PortName=”Accelerometer” BufferSize=”2500” AveragedItemsForFiltering=”20”/>
<DataSource Type=”Tool” Id=”Gyroscope” PortName=”Gyroscope” BufferSize=”2500” AveragedItemsForFiltering=”20”/>
<DataSource Type=”Tool” Id=”Magnetometer” PortName=”Magnetometer” BufferSize=”2500” AveragedItemsForFiltering=”20”/>
<DataSource Type=”Tool” Id=”TiltSensor” PortName=”TiltSensor” BufferSize=”2500” AveragedItemsForFiltering=”20” TiltSensorWestAxisIndex=”1” AhrsAlgorithm=”NONE/MADGWICK_IMU/MAHONY_IMU” AhrsAlgorithmGain=”1.5” />
<DataSource Type=”Tool” Id=”OrientationSensor” PortName=”OrientationSensor” BufferSize=”2500” AveragedItemsForFiltering=”20” AhrsAlgorithm=”MADGWICK_MARG” AhrsAlgorithmGain=”1.5” />
</DataSources>
<OutputChannels>
<OutputChannel Id=”TrackerStream” >
<DataSource Id=”Accelerometer”/>
<DataSource Id=”Gyroscope”/>
<DataSource Id=”Magnetometer”/>
<DataSource Id=”TiltSensor”/>
<DataSource Id=”OrientationSensor”/>
</OutputChannel>
</OutputChannels>
</Device>

Migrated from https://app.assembla.com/spaces/plus/tickets/802/details

@Sunderlandkyl Sunderlandkyl added this to the Release Plus-Future milestone Sep 21, 2017
@adamrankin
Copy link
Member

This has been completed at some point.

@adamrankin
Copy link
Member

Or, is the goal to move them into the tool elements?

@adamrankin adamrankin reopened this Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants