Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with types in the problem expert #258

Open
roveri-marco opened this issue Jan 17, 2023 · 8 comments
Open

Problems with types in the problem expert #258

roveri-marco opened this issue Jan 17, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@roveri-marco
Copy link
Collaborator

roveri-marco commented Jan 17, 2023

The types in the problem expert does not seem to be correct. Indeed, although they are specified correctly in the terminal, the problem.pddl file generated is wrong and causes popf to go in seg fault!

The source code that show the problem: assignment_3_5.zip

ros2 launch assignment_3_5 plansys2_simple_example_launch.py on terminal one
ros2 run plansys2_terminal plansys2_terminal
then in the terminal execute the commands
set instance capacity_4 capacity_number
source assignment_3_5/launch/commands

If you then issue a get plan the answer is no plan, but an investigation show that popf goes seg fault since the problem file is not precise.

The generated (correct) domain.pddl file domain.pddl.txt

The generated (wrong) problem.pddl file problem.pddl.txt

The plan file generated when popf is called plan.txt

The commands: commands.txt

The correct problem file to generate: good-problem.pddl.txt

@fmrico
Copy link
Contributor

fmrico commented Feb 9, 2023

Hi @roveri-marco

I see that the bug is that it uses the base type instead the derived type of an instance, right?

@fmrico fmrico added the bug Something isn't working label Feb 9, 2023
@roveri-marco
Copy link
Collaborator Author

Not sure it is only that...

@antbono
Copy link

antbono commented May 15, 2023

Hi everyone!

I think I also have an issue related to the domain expert... Like in the generated domain.pddl of @roveri-marco, also mine has a empty block for functions. This automatically generated block is an issue when the used solver does not support pddl 2.1

@antbono
Copy link

antbono commented May 16, 2023

I tried to use the same example of @roveri-marco and I had the same issue. Moreover I cannot use the command
source assignment_3_5/launch/commands

@roveri-marco
Copy link
Collaborator Author

I tried to use the same example of @roveri-marco and I had the same issue. Moreover I cannot use the command source assignment_3_5/launch/commands

It should work... Can you share the output?

@roveri-marco
Copy link
Collaborator Author

We can optimize the output to remove the function if no functions declared. It should be possible. I'll take care in one of the possible next pull request.

@antbono
Copy link

antbono commented May 17, 2023

It should work... Can you share the output?

The output of the terminal is: Failing to open file "assignment_3_5/launch/commands"

I also found the following compilation error that could be related to this unexpected behavior

Screenshot from 2023-05-17 11-42-25

Strangely this error is reported only at the first attempt of building the package. If i try to build again everything goes well

@antbono
Copy link

antbono commented May 17, 2023

It works specifying the absolute path of the commands file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants