Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppleIntelInfo.kext - Severe incompatibility issue with i9-7980XE - please resolve ! #22

Open
KGP opened this issue Oct 17, 2017 · 8 comments

Comments

@KGP
Copy link

KGP commented Oct 17, 2017

Hi Pike,

below an urgent reminder and request to update AppleIntelInfo.kext for i9-7980XE compatibility. Your current AppleIntelInfo.kext distribution is at odd with the latter processor. Immediate reboot when executing "sudo kextload AppleIntelInfo.kext" with the i9-7980XE...

Please resolve this issue as soon as possible...

Many thanks in advance,

KGP

i9

@esetnik
Copy link

esetnik commented Oct 31, 2017

I have instant reboot when kextload AppleIntelInfo.kext with i7-7700k and HWP enabled following https://www.tonymacx86.com/threads/skylake-hwp-enable.214915/

@KGP
Copy link
Author

KGP commented Oct 31, 2017

In contrary to your exotic XCPM approach, I use Pike's ssdtPRGen.sh and ssdt.aml with SMBIOS iMac17,1... Even with this fully compatible and fully functional XCPM implementation, I witness an immediate reboot when executing "sudo kextload AppleIntelInfo.kext" with my i9-7980XE... Up to my knowledge, "sudo kextload AppleIntelInfo.kext" and AppleIntelInfo.kext work absolutely flawless with any other Skylake-X processor! I myself formerly used a i7-7800X without any issues on the same build and with the same system configuration!

@KGP
Copy link
Author

KGP commented Nov 9, 2017

Pike, how are doing? Hope everything is just fine there!

Is there any severe incompatibility problem between AppleIntelInfo.kext and the i9-7980XE or what is the reason that you do not respond at all on my issue report for already more than 23 days? I would extremely appreciate if you could come up with a short feedback or update as soon as possible..

Many thanks in advance, KGP

@Piker-Alpha
Copy link
Owner

Sorry folks. I'm so busy trying to keep up with everything and since I don't have a fix handy, replying seemed pointless. Let's try to move this forward now that you have my attention ;)

First. Change all compiler directives to 0:

#define REPORT_MSRS			1
#define REPORT_RAPL_MSRS		1
#define REPORT_HWP				1
#define REPORT_HDC				1
#define REPORT_IGPU_P_STATES	1
#define REPORT_C_STATES		1
#define REPORT_IPG_STYLE		1
#define ENABLE_HWP				1
#define WRITE_LOG_REPORT		1

Now recompile and try again.

@KGP
Copy link
Author

KGP commented Nov 12, 2017

Thanks for your response, Pike! My system currently is broken. As soon I am up again, I will come back with some feedback to your above instructions.

@KGP
Copy link
Author

KGP commented Nov 20, 2017

Sorry for the delay in my response .. it took me several days to fix my pc...

Well I am able to set all compiler directives to 1 apart from #define REPORT_MSRS..

#define REPORT_MSRS set to 1 causes the reboot with the i9-7980XE...

@Piker-Alpha
Copy link
Owner

Piker-Alpha commented Nov 22, 2017

Have you tried to only set REPORT_MSRS to 1?

If that fails, with all others set to 0, then please add a return statement after a few lines in:

void AppleIntelInfo::reportMSRs(void)

To see if you can locate the exact spot that triggers the problem.

@KGP
Copy link
Author

KGP commented Nov 22, 2017

o.k. with

#define REPORT_MSRS				1
#define REPORT_RAPL_MSRS		0
#define REPORT_HWP				0
#define REPORT_HDC				0

#define REPORT_IGPU_P_STATES	0
#define REPORT_C_STATES			0
#define REPORT_IPG_STYLE		0
#define REPORT_INTEL_REGS		0

#define ENABLE_HWP				0

#define WRITE_LOG_REPORT		0

I cannot even compile AppleIntelInfo.plist and I get the following compilation errors:

In file included from /Users/kgp/Desktop/AppleIntelInfo-master/AppleIntelInfo/AppleIntelInfo.cpp:13:
/Users/kgp/Desktop/AppleIntelInfo-master/AppleIntelInfo/AppleIntelInfo.h:107:10: warning: 
      'IOLOG' macro redefined [-Wmacro-redefined]
        #define IOLOG(fmt, args...) os_log_with_type(OS_LOG_DEFAULT, OS_...
                ^
/Users/kgp/Desktop/AppleIntelInfo-master/AppleIntelInfo/AppleIntelInfo.h:102:10: note: 
      previous definition is here
        #define IOLOG(fmt, args...) IOLog(fmt, ##args)
                ^
/Users/kgp/Desktop/AppleIntelInfo-master/AppleIntelInfo/AppleIntelInfo.cpp:1062:7: error: 
      use of undeclared identifier 'gCheckC7'
                if (gCheckC7)
                    ^
/Users/kgp/Desktop/AppleIntelInfo-master/AppleIntelInfo/AppleIntelInfo.cpp:1087:7: error: 
      use of undeclared identifier 'gCheckC7'
                if (gCheckC7)
                    ^
1 warning and 2 errors generated.

** BUILD FAILED **


The following build commands failed:
	CompileC build/AppleIntelInfo.build/Release/AppleIntelInfo.build/Objects-normal/x86_64/AppleIntelInfo.o AppleIntelInfo/AppleIntelInfo.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Other question:
If I would finally succeed in compiling AppleIntelInfo just with REPORT_MSRS to 1 how does the return statement looks like?

IOReturn result		= kIOReturnSuccess;

?

And where to place it in AppleIntelInfo.h? Here?

#ifdef REPORT_MSRS
	void reportMSRs(void);

	#ifdef REPORT_HWP
	void reportHWP(void);
	#endif

	#ifdef REPORT_HWP
	void reportHDC(void);
	#endif

	bool hasCPUFeature(long targetCPUFeature);

	bool logMSRs		= true;		// Set <key>logIGPU</key> to <false/> in Info.plist to disable this feature.
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants