Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small bugs #41

Open
asherikov opened this issue Nov 18, 2024 · 1 comment
Open

small bugs #41

asherikov opened this issue Nov 18, 2024 · 1 comment

Comments

@asherikov
Copy link

Inconsistent cmake namespace: when building without ROS, the namespace is data_tamer:: instead of data_tamer_cpp::, in general all data_timer strings in https://github.com/PickNikRobotics/data_tamer/blob/main/data_tamer_cpp/CMakeLists.txt#L141 should be replaced with ${PROJECT_NAME}.

Package manifest lacks mcap build dependency -- liblz4-dev.

@asherikov
Copy link
Author

Enforcing -Werror results in a failure in mcap when building with clang:

data_tamer_cpp/3rdparty/mcap/include/mcap/internal.hpp:72:28: error: implicit conversion loses integer precision: 'int' to 'uint16_t' (aka 'unsigned short') [-Werror,-Wimplicit-int-conversion]

return uint16_t(data[0]) | (uint16_t(data[1]) << 8);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant