Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it so that image paths ALWAYS are consistently full paths determined by the backend. The frontend should not be building image urls! #49

Open
PhilippMDoerner opened this issue Apr 30, 2022 · 4 comments
Open

Make it so that image paths ALWAYS are consistently full paths determined by the backend. The frontend should not be building image urls! #49

PhilippMDoerner opened this issue Apr 30, 2022 · 4 comments
Labels
refactor Refactor something for readability or to improve simplicity

Comments

@PhilippMDoerner
Copy link
Owner

No description provided.

@PhilippMDoerner
Copy link
Owner Author

Culprit areas where this happens:
campaign-overview component (CampaignOverview serialization)
home2-component (CampaignOverview Serialization)
background-image component (CampaignOverview Serialization)
sidebar-component (CapmaignOverviewSerialization)

@PhilippMDoerner
Copy link
Owner Author

Another culprit:
map (MapSerialization)

I'm pretty sure the Image-Gallery component also fucks up

@PhilippMDoerner
Copy link
Owner Author

campaign component (CampaignSerialization)

@PhilippMDoerner
Copy link
Owner Author

Also the error 400 page

@PhilippMDoerner PhilippMDoerner added enhancement New feature or request refactor Refactor something for readability or to improve simplicity and removed enhancement New feature or request labels Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactor something for readability or to improve simplicity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PhilippMDoerner