Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen weak refs when sorting in-place #17569

Open
toddr opened this issue Feb 18, 2020 · 3 comments
Open

Strengthen weak refs when sorting in-place #17569

toddr opened this issue Feb 18, 2020 · 3 comments
Labels
Bug do not merge Don't merge this PR, at least for now type-core

Comments

@toddr
Copy link
Member

toddr commented Feb 18, 2020

In #16162 , We determined to revert f6107ca in commit d830645 because it was breaking MLEHMANN/AnyEvent-HTTP-2.23. The plan was to put the commit back into 5.30 but I think we're too late in that cycle and the current one to put it back in.

So my question: Do we want to action this in v5.33.1 or do we want to drop this all together? What notifications will need to be made to make this happen?

@xsawyerx
Copy link
Member

Honestly, I do consider this a bug and I'm unhappy we need to keep a bug because a single person is being stubborn.

@xsawyerx xsawyerx added the Bug label Feb 18, 2020
@dur-randir
Copy link
Member

But we already have a 'sort' pragma that can change behaviour/implementation. Can it be expanded to provide the desired feature? It could be useful at times.

@xsawyerx
Copy link
Member

I do have some old insult-laden email exchanges (sigh) which might have had that as a rejected suggestion, but I'm not sure. I'll need to check.

In any case, I think the objection was to force our hand to not make a change the said module author considered unnecessary (at least that's the word I'm going with). I don't think providing another option to achieve would convince said author. (I could be wrong.)

@xsawyerx xsawyerx added the do not merge Don't merge this PR, at least for now label Jun 20, 2020
@hvds hvds removed this from the 5.33.1 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug do not merge Don't merge this PR, at least for now type-core
Projects
None yet
Development

No branches or pull requests

5 participants