Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divergence from upstream: mconfig -X #43

Closed
jmdh opened this issue Oct 23, 2017 · 5 comments
Closed

Divergence from upstream: mconfig -X #43

jmdh opened this issue Oct 23, 2017 · 5 comments
Assignees
@jmdh

Comments

@jmdh
Copy link
Member

jmdh commented Oct 23, 2017

Recording a divergence to upstream dist created by #42 (ref #28)
@jmdh jmdh assigned arc Oct 23, 2017
@arc
Copy link
Contributor

arc commented Oct 23, 2017

Now submitted upstream as rmanfredi/dist#14

@jmdh
Copy link
Member Author

jmdh commented Oct 25, 2017

Thanks! As that has now been merged, I'm taking ownership of this and will test that the upstream change is compatible with our repository.

@jmdh jmdh assigned jmdh and unassigned arc Oct 25, 2017
@jkeenan
Copy link
Contributor

jkeenan commented Oct 26, 2017

Could I ask for some clarification? What is it within our prerogative to change in perl5-metaconfig without having to worry about pushing something upstream?

@jmdh
Copy link
Member Author

jmdh commented Oct 27, 2017

Any time we make a change to the tools, we create a divergence from upstream, and any such divergence (unless it is merely cosmetic) takes us further away from the goal of dropping our local "forks" entirely (#28).

This goal is important for Debian, because it allows us to create a sane build environment using the upstream dist, rather than having to worry about the freeness/modifiability of the tools in this repository. But regardless of that, I think we can probably agree that the copies of the tools in this repository aren't really in an ideal state to hack on?

I'd suggest any follow-ups on this discussion happen in #28 rather than here. I am very interested to hear other opinions on this.

arc added a commit that referenced this issue Apr 19, 2018
@arc
bin/mconfig: pull more changes from rmanfredi/dist#14
2a192f8 
In particular, this allows the -X option to be named in the .package file
(which would have saved some confusion for Tux).

This also reduces the amount of divergence from upstream dist, which goes
a small way to addressing #43.
@jmdh
Copy link
Member Author

jmdh commented May 30, 2018

Upstream dist works with the perl metaconfig bits (tested as part of Debian's integration work for 5.28. Closing.

@jmdh jmdh closed this as completed May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmdh jmdh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arc @jkeenan @jmdh