diff --git a/nxc/protocols/smb.py b/nxc/protocols/smb.py index a0c2e5c21..b7d44307f 100755 --- a/nxc/protocols/smb.py +++ b/nxc/protocols/smb.py @@ -257,7 +257,6 @@ def enum_host_info(self): except Exception as e: self.logger.debug(f"Error logging off system: {e}") - def print_host_info(self): signing = colored(f"signing:{self.signing}", host_info_colors[0], attrs=["bold"]) if self.signing else colored(f"signing:{self.signing}", host_info_colors[1], attrs=["bold"]) smbv1 = colored(f"SMBv1:{self.smbv1}", host_info_colors[2], attrs=["bold"]) if self.smbv1 else colored(f"SMBv1:{self.smbv1}", host_info_colors[3], attrs=["bold"]) @@ -1010,7 +1009,6 @@ def groups(self): def users(self): if len(self.args.users) > 0: self.logger.debug(f"Dumping users: {', '.join(self.args.users)}") - return UserSamrDump(self).dump(self.args.users) def hosts(self): @@ -1491,12 +1489,14 @@ def dpapi(self): credential.url, ) - if dump_cookies: + if dump_cookies and cookies: self.logger.display("Start Dumping Cookies") for cookie in cookies: if cookie.cookie_value != "": self.logger.highlight(f"[{credential.winuser}][{cookie.browser.upper()}] {cookie.host}{cookie.path} - {cookie.cookie_name}:{cookie.cookie_value}") self.logger.display("End Dumping Cookies") + elif dump_cookies: + self.logger.fail("No cookies found") vaults = [] try: @@ -1537,6 +1537,9 @@ def dpapi(self): credential.url, ) + if not (credentials and system_credentials and browser_credentials and cookies and vaults and firefox_credentials): + self.logger.fail("No secrets found") + @requires_admin def lsa(self): try: