Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library and secondary IDs #48

Closed
DeniseSl22 opened this issue Jul 31, 2017 · 4 comments
Closed

Library and secondary IDs #48

DeniseSl22 opened this issue Jul 31, 2017 · 4 comments

Comments

@DeniseSl22
Copy link
Collaborator

Hi all, (again about the library, sorry about that ;)....)

In the Pathvisio library, secondary identifiers of ChEBI are included as well (Marvin found this for bicarbonate). I think for a new Pathvisio release, we should remove these secondary IDs as a option; and replace all secondary ChEBIs with primary in WPs. Since the secondary IDs are not mapped via bridgeDB.

@marvinm2
@egonw
@mkutmon

@DeniseSl22
Copy link
Collaborator Author

After consulting with Jonathan, he told me that the library(search function in Pathvisio) uses the content of BridgeDB databases.
So, if any secondary metabolites IDs are being found in the "library", it is because they are in the metabolites bridgeDB file. We do not need a new Pv release for this change.

Is this something we want to include in the bridge file (I have other examples, where I could not create a mapping, because the secondary ID was used in a dataset....)?
Or do we just want the primary ones included, and another way to map the secondary to the primary IDs?

@mkutmon
Copy link
Collaborator

mkutmon commented Sep 1, 2017

@DeniseSl22 did you move this issue to the bridgedb repo? then I close it here.

@DeniseSl22
Copy link
Collaborator Author

Nope not yet; I will do it right away :)
But it is a problem which we do not have the solution for right now (according to Chris and Egon)...

@DeniseSl22
Copy link
Collaborator Author

Moved to bridgedb/BridgeDb#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants