Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LORE...sorta] Switches the L6's caliber to 7.62x51mm #28445

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

PopeDaveThe3th
Copy link
Contributor

What Does This PR Do

Title. Also changes a few names and descriptions for readability.

Does not change any stats of the weapon or its ammunition.

Why It's Good For The Game

The L6 being chambered in 5.56 didn't make much sense given its higher damage and relatively low magazine capacity. Also, the icon for the bullet it fires is literally called a 7.62 round already.

Testing

  • loaded in
  • observed weapon and ammo
  • fired weapon
  • success

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Changed L6 to 7.62, changed a few descriptions and names.
/:cl:

@Spaghetti-bit
Copy link
Contributor

image
This this is based off of is the FN Minimi or SAW. It's generally chambered in 7.62x51mm 👍

Copy link
Contributor

@Spaghetti-bit Spaghetti-bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stop me if I'm wrong, but we still have other weapons that use 556 casings. Namely the MGL-90 or something similar.

@PopeDaveThe3th
Copy link
Contributor Author

Stop me if I'm wrong, but we still have other weapons that use 556 casings. Namely the MGL-90 or something similar.

We do, but the L6 does more damage than they do. The L6 bullets also can't be used by the M-90 or M26, last I checked. They use a different 5.56 round.

@Spaghetti-bit
Copy link
Contributor

@PopeDaveThe3th

This is the round the M-90GL Carbine uses. Which is only used by that weapon. Seems good, approval given on that regard, let me look into the rest of it.
image

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map labels Feb 19, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 19, 2025
@Bm0n
Copy link
Contributor

Bm0n commented Feb 20, 2025

This this is based off of is the FN Minimi or SAW. It's generally chambered in 7.62x51mm 👍

FN Minimi is much more commonly chambered in 5.56x45 or in the case of the M249 SAW purely a 5.56x45 weapon. A 7.62x51mm version does exist, it's what the prototype was originally chambered in but it's not nearly as produced as the 5.56x45 version. https://en.wikipedia.org/wiki/FN_Minimi#Minimi_7.62

You might have confused it with the FN MAG or M240 which only uses 7.62x51mm.

Ultimately does this matter? Not really. The L6 can be whatever we want it to be, it's not a real gun.

@Burzah Burzah added the Tweak This PR tweaks something ingame label Feb 20, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Feb 23, 2025
Copy link
Contributor

@BiancaWilkson BiancaWilkson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 24, 2025
@Burzah Burzah added this pull request to the merge queue Mar 1, 2025
Merged via the queue into ParadiseSS13:master with commit bd13285 Mar 1, 2025
19 checks passed
@m-dzianishchyts
Copy link
Contributor

God please I beg you to provide an UpdatePath script when editing type paths 🤯

@PopeDaveThe3th PopeDaveThe3th deleted the l6'n-time branch March 2, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Map Edit This PR will modify a map Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants