Adds public notes #28373
Open
Adds public notes #28373
+130
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrabang
added
the
Administration
| @@ -1,4 +1,4 @@ | |||
| /proc/add_note(target_ckey, notetext, timestamp, adminckey, logged = 1, checkrights = 1, show_after = TRUE, automated = FALSE, sanitise_html = TRUE) // Dont you EVER disable this last param unless you know what you're doing | |||
There was a problem hiding this comment.
Edit comment to say automated.
There was a problem hiding this comment.
Comment changed to // Dont you EVER disable 'sanitise_html', only automated systems should use this
Comment on lines
+289
to
+293
| var/target_ckey = query_find_note_edit.item[1] | ||
| var/text = query_find_note_edit.item[2] | ||
| var/adminckey = query_find_note_edit.item[3] | ||
| var/automated = query_find_note_edit.item[4] | ||
| var/public = query_find_note_edit.item[5] |
There was a problem hiding this comment.
We don't need the text or target ckey here surely right?
There was a problem hiding this comment.
Its used in the logging.
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
ParadiseSS13-Bot
added
-Status: Awaiting review
|
I don't know if "public notes" is the right wording to convey what's being done. Public would infer that everyone can see your notes when in reality it's between the admins and the player who was noted. Visible notes instead? Or forgo the word public entirely and call the panel "my notes" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Adds public notes. Old notes are grandfathered in as private notes. Upon creation of a new note, admins will be able to choose if its public or private. Admins can toggle notes created by ONLY THEM between private and public. Only you can see your own public notes.
Why It's Good For The Game
Admins want it as an option. Its also helpful and healthy for the playerbase.
Testing
A lot of testing. Including setting up a DB. (ignore that I'm a headcoder and haven't done it yet.)
Player view.
Admin view.
Edit: The player-side is darkmode now!
Declaration
Changelog
🆑
add: Public player notes. View these with the "Show My Notes" OOC verb.