Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI eye movement is consistently sluggish #28326

Closed
asciodev opened this issue Feb 10, 2025 · 0 comments · Fixed by #28327
Closed

AI eye movement is consistently sluggish #28326

asciodev opened this issue Feb 10, 2025 · 0 comments · Fixed by #28327
Labels
Bug This is a bug in our game code

Comments

@asciodev
Copy link
Contributor

Given a issue to this, general movement feel's sluggish at best, and is really annoying if it isn't instant like it's supposed to be. Your input feels like a big 500ms delay and if you stop moving your keys, it shoves you 1 extra tile into the direction you were going which is...???.

Originally posted by @XFirebirdX in #28161
asciodev added a commit to asciodev/Paradise that referenced this issue Feb 10, 2025
@asciodev
Fix sluggish AI eye movement
82b8c09 
Fixes ParadiseSS13#28326

With the AI eye refactor, a `Moved()` callback was implicitly added to
each call to `set_loc` on a camera eye. As camera eyes are completely
invisible and do not directly interact with the game world, this extra
processing isn't necessary. Removing it also removed the noted
sluggishness.
@asciodev asciodev mentioned this issue Feb 10, 2025
Merged
1 task
@PollardTheDragon PollardTheDragon added the Bug This is a bug in our game code label Feb 11, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2025
@asciodev
Fix sluggish AI/camera eye movement (#28327)
c895b91 
* Fix sluggish AI eye movement

Fixes #28326

With the AI eye refactor, a `Moved()` callback was implicitly added to
each call to `set_loc` on a camera eye. As camera eyes are completely
invisible and do not directly interact with the game world, this extra
processing isn't necessary. Removing it also removed the noted
sluggishness.

* Re-adds Moved() call to set_loc, adds parameters

The Moved() call removed in the previous commit was not actually
completely unnecessary, or newly added. Rather, new parameters were
added that were not accounted form namely `momentum_change`. This commit
re-adds parent proc call to set_loc for camera eyes, and adds the
correct parameter values to Moved() in `/atom/movable/proc/set_loc`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug This is a bug in our game code
Projects
Paradise Station Issue Tracker
Status: Resolved issues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sluggish AI/camera eye movement asciodev/Paradise
2 participants
@asciodev @PollardTheDragon