move_towards the right spot #28242
Merged
move_towards the right spot #28242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
1080pCat
approved these changes
Feb 4, 2025
ParadiseSS13-Bot
added
-Status: Awaiting review
warriorstar-orion
approved these changes
Feb 4, 2025
ParadiseSS13-Bot
added
-Status: Awaiting merge
Burzah
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Corrects a bug in
/datum/move_loop/has_target/move_towardsthat made it go slightly off-track and fail to update its target after a diagonal move.Fixes #28229
The issue here is that the code is trying to avoid recalculating on the first part of a diagonal move, but got the check backwards, so it only recalculates on the first part of a diagonal move.
Why It's Good For The Game
Accurate movement is good. Stuck meteors are bad.
Testing
Sent a meteor flying 5 tiles southeast without the PR. Missed by a tile and never corrected.
Sent a meteor flying 5 tiles southeast with the PR. Hit the target and despawned.
Declaration
Changelog
🆑
fix: Meteors no longer get stuck after missing the station.
/:cl: