Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jetpacks and speedbikes #28222

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Fix jetpacks and speedbikes #28222

merged 5 commits into from
Feb 13, 2025

Conversation

FunnyMan3595
Copy link
Contributor

@FunnyMan3595 FunnyMan3595 commented Feb 2, 2025 •
edited
Loading

What Does This PR Do

Fixes #28219
Fixes #28246
Gives speedbikes their intended ability to move in space.

Why It's Good For The Game

Bugs bad.

Testing

Moved around with a jetpack, let myself drift in both cardinal and diagonal directions.
Moved around with a speedbike, let myself drift in both cardinal and diagonal directions.

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Jetpacks no longer teleport around.
fix: Speedbikes no longer teleport around.
fix: Speedbikes can fly in space.
/:cl:

@FunnyMan3595
Copy link
Contributor Author

This ended up a bit more complex than I like, because I discovered that the momentum_change argument to Moved() was broken, so I had to fix that.

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Feb 2, 2025
@FunnyMan3595 FunnyMan3595 added the Fix This PR will fix an issue in the game label Feb 2, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Requested This PR has a pending testmerge request -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 2, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Feb 2, 2025
@FunnyMan3595 FunnyMan3595 changed the title Fix jetpacks Fix jetpacks and speedbikes Feb 4, 2025
@milk-is-cool
Copy link

It seems like simplemob movement in space has a similar issue when they move diagonally and rocket all over the place

@ParadiseSS13-Bot ParadiseSS13-Bot removed the Testmerge Requested This PR has a pending testmerge request label Feb 13, 2025
Burzah
Burzah approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been on TM for an extended period of time with no issues.
Approved.

@Burzah Burzah added this pull request to the merge queue Feb 13, 2025
Merged via the queue into ParadiseSS13:master with commit cb7c658 Feb 13, 2025
17 checks passed
@m-dzianishchyts m-dzianishchyts mentioned this pull request Feb 18, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Burzah Burzah Burzah approved these changes

Assignees
No one assigned
Labels
-Status: Awaiting review This PR is awaiting review from the review team Fix This PR will fix an issue in the game Testmerge Active This PR is currently testmerged on production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speedbikes teleporting worse than jetpacks. Jetpacks teleporting/increased speed
4 participants
@FunnyMan3595 @milk-is-cool @Burzah @ParadiseSS13-Bot