-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn EncodeDNABlock proc into a define #28186
base: master
Are you sure you want to change the base?
Conversation
Did you get any performance boost? Can you mesure it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By making this a define, we should also change the capitalization of it
This is to reflect it now being a define.
Not tested yet. I pressed the synch button without thinking. |
@Drsmail I asked whether I need to benchmark it and to quote AA (the only one who responded): "Why is this not a define. That's player count * 52 proc overhead for no reason" |
Ok, tested again. (This time I got the awesome power of blindness, but same same otherwise.) |
What Does This PR Do
Turns the proc EncodeDNABlock into a define. It is a one liner that improves readability but otherwise eats up performance, especially during startup.
Why It's Good For The Game
Less startup lag.
Testing
Spawned in as geneticist. Followed the guide on the wiki to make a humanized monkey. Changed the humanized monkey's gender via setting UI block 37. Irradiated SE block 1 until above DAC. Made single block injector and injected myself. Got morphing power. Morphing power worked.
Spawned in as clown. Shot a laser gun and clumsily shot myself in the foot on first shot. Removed clumsy gene via player panel. Shot rest of laser gun charge. Did not shoot myself in the foot.
Declaration
Changelog
NPFC