Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slower plasma fire and temperature decay #28171

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

FunnyMan3595
Copy link
Contributor

What Does This PR Do

Slows down the innate temperature decay (space cooling) of the station, especially where the gas density is above 100 moles (a normal room) or below 1 mole.
Makes plasma fires burn about 5x slower, so they last longer.

Why It's Good For The Game

Space cooling is important for mechanics reasons, as it prevents heat from spreading way too far after a single plasma fire. However, it was overly aggressive compared to LINDA and MILLA 1, especially in cases like the SM, where the gas is dense.

Since space cooling has been toned down, we can also slow down plasma fires. The bottleneck there is toxins mixing, which ends up with slightly higher temperatures now than before this PR. This makes fires a more serious threat, and increases the importance of firefighting techniques, especially nanofrost.

Testing

Big plasma fire in science.
Small plasma fire in toxins mixing (the burn chamber, not the people chamber).


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Fires will last about 5x as long. Bring your nanofrost, atmosians!
tweak: Cooling an SM with >100 moles of gas will be harder.
/:cl:

Sorry, something went wrong.

@FunnyMan3595
Copy link
Contributor Author

!build_rust

@FunnyMan3595 FunnyMan3595 added the Tweak This PR tweaks something ingame label Jan 29, 2025
@paradisess13 paradisess13 bot requested a review from AffectedArc07 as a code owner January 29, 2025 10:35
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Jan 29, 2025
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 30, 2025
@FunnyMan3595
Copy link
Contributor Author

!build_rust

@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 31, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 31, 2025
@FunnyMan3595
Copy link
Contributor Author

@AffectedArc07 This is synced and built past your build change, so you probably want to wait on the outcome of your TM before approving.

@AffectedArc07
Copy link
Member

@AffectedArc07 This is synced and built past your build change, so you probably want to wait on the outcome of your TM before approving.

Mine has been fine and it's awaiting full merge, this can follow shortly after.

@Spaghetti-bit
Copy link
Contributor

Have you checked how this would affect toxins? Bomb making and etc. Wondering if the guide needs to be updated. @FunnyMan3595

@FunnyMan3595
Copy link
Contributor Author

Have you checked how this would affect toxins? Bomb making and etc. Wondering if the guide needs to be updated. @FunnyMan3595

The bottleneck there is toxins mixing, which ends up with slightly higher temperatures now than before this PR.

Bombs themselves are unaffected, they use a completely different system.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Feb 2, 2025
@FunnyMan3595
Copy link
Contributor Author

!build_rust

@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Feb 2, 2025
@Burzah Burzah added this pull request to the merge queue Feb 7, 2025
@Burzah Burzah removed this pull request from the merge queue due to a manual request Feb 7, 2025
@Burzah Burzah added this pull request to the merge queue Feb 7, 2025
Merged via the queue into ParadiseSS13:master with commit 9be5e7d Feb 7, 2025
17 checks passed
Burzah added a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants