Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds wizard item: Plague Talisman #28150

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

EmeraldCandy
Copy link
Contributor

@EmeraldCandy EmeraldCandy commented Jan 27, 2025

What Does This PR Do

Adds the Plague Talisman to the wizard's spellbook for 2 points. This item is intended a side-grade equivalent to the necromatic stone. When purchased, the wizard receives 5 plague talismans. When used on a corpse with a mind in it, the victim will be turned into a (NON-NECRO PLAGUE) zombie and is loyal to the wizard and makes wiz/zombies virus immune so they wont be affected by their own fun.. Each zombie is given a disease upon their creation that they carry, to which they are able to spread via attacks with the given claw items. The disease list has been curated for harsh but not biohazard level diseases, leaving out some nigh-gaurenteed death sentences such as GBS/Kuru. Most transformation diseases (besides advanced kingstons) have been omitted.

Currently, the zombie claws do 35 force, which is 5 less than the claymores given by the necromatic stone, due to both having more potential zombies and the additions of the plagues. This can be changed as needed.

Additionally, three additional plague-zombie only diseases have been added:

Mystic Malaise
At maximum stages, will cause the user to vomit up "spacematter" vomit, which for 15 seconds will attempt to drain air out of a room before going inert.
Cure: Liquid dark matter

Wand Rot
At maximum stages, will slowly burn the user. With a low chance, users will sneeze, causing them to erupt a fireball out in a random direction.
Cure: Acetaldehyde

Grut Gut
At maximum stages, will sometimes cause the user to vomit with such intensity that they will be propelled backwards and crash into people/objects.
cure: Stabilizing Agent

Why It's Good For The Game

New wizard items are interesting, and more options for minions could be fun. These thralls are similar to the necromatic stone, though technically weaker than the weapons given to the skeleton thralls. However, zombies are unable to wield weaponry, and rely on their claws, thus preventing the wizard from giving out equipment to their new thralls (such as staffs of resurrection).

Images of changes

(thank you Exusa for the sprite!)
dreammaker_5VG9m3nyfg

Testing

  • Tested for converting alive/mindless/already slaved bodies
  • ensured proper mindslaving
  • ensured the victim gets the proper welcome message
  • ensured the claws summon as intended
  • ensured claws dispelled as intended
  • ensured claws inflicted diseases as intended
  • ensured each zombie was given their own individual disease
  • ensured zombies rot properly
  • ensured zombies revive properly
  • ensured zombies could not be given items
  • ensured mindless zombies dont spread the necro plague due to AI behavior
  • ensured you couldnt manually spread zombie virus with a syringe
  • infected self with each disease one at a time to ensure functionality

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Added plague talismans for the wizard
add: Added the plague claw spell for plague zombie use
add: Added three plague zombie diseases: Wand Rot, Grut Gut, Mystic Malaise
imageadd: Plague talisman icon
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 27, 2025
Copy link
Contributor

@Scribble-Sheep Scribble-Sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar/spelling/flow touchups/suggestions.

@Scribble-Sheep
Copy link
Contributor

And also, I see this has been reworked from being a direct virus vector into more of a conversion spell. I like it~
Hopefully it'll be fun in practice.

@TravisAngeI
Copy link

I think the zombies should be told what virus they have on revival so they know what they're infecting people with, could have the minor zombies play defense with their 35 force claws and the major zombies play offense with their virus-y claws

@Burzah Burzah added the Balance This PR will modify how effective something is or isnt label Jan 28, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jan 28, 2025
@EmeraldCandy EmeraldCandy requested a review from lewcc February 1, 2025 05:12
@SynthTwo
Copy link
Contributor

SynthTwo commented Feb 6, 2025

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Feb 6, 2025
@silverplatedelta
Copy link
Contributor

silverplatedelta commented Feb 8, 2025

Hey there, After some internal discussion, the balance team has some significant concerns about this item, with three members currently objecting to its addition in its current state.

The three members objecting have left the following comments:

[Objector 1]: major diseases can cripple a station running at normal capacity, add in a hectic round like wizard where doctors might not even stay in medbay and you have a 1/3 chance to instantly wipe out the station in one lucky cast of brainrot, gbs, etc. This would be way too strong.

[Objector 2]: Agreeing with [Objector 1] here, some of the diseses are ROUGH and all the wizard has to do is destoy medbay or viro to wipe the station quickly

[Objector 3] Agreeing with above, If the wizard gets rolling, this is going to kill or disable most of the crew.

Personally, I would suggest making it so the disease spread to players via claws cannot be otherwise spread (meaning if you get a flu zombie, that flu will only be spread via zombie attacks. ) This however would require ALOT more coding.

I would also suggest pinging the balance team in coding chat to discuss how to tune this item.

@EmeraldCandy EmeraldCandy marked this pull request as draft February 10, 2025 23:07
@EmeraldCandy EmeraldCandy marked this pull request as ready for review February 12, 2025 02:12
@EmeraldCandy
Copy link
Contributor Author

As suggested, made all diseases marked with a NON_CONTAGIOUS flag. Removed some diseases from the pick pool. Additionally, added three new wizard-only diseases: Grut Gut, Mystic Malaise, and Wand Rot

@Stoniest
Copy link
Contributor

Stoniest commented Feb 22, 2025

Really like the new diseases and the fact that the cures for them aren't extremely simple and take a bit to make.

Maybe at a later date one of these could possibly be a real major disease event disease.

@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Requested This PR has a pending testmerge request label Feb 22, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Balance This PR will modify how effective something is or isnt Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants