Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soulstones into possessed items #27980

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

FunnyMan3595
Copy link
Contributor

@FunnyMan3595 FunnyMan3595 commented Jan 15, 2025

What Does This PR Do

Soulstones can now create possessed items by using an occupied soulstone on (almost) any item.
When a possessed item created from a soulstone dies, it will revert to being a shade, as if it had been released from the soulstone directly.
Certain possessed items can now read, and a few can write as well.
Pressing your "use held item" keybind while a possessed item will use the item.
Committing suicide with a soul stone stuffs you into it.
Using an empty soul stone in hand will give a custom suicide prompt.
The chaplain's mysterious old shard is no longer single-use.
Many possessed item bugs have been fixed.

Why It's Good For The Game

More content for the chaplain, and RP opportunities with crew turned into possessed items.

Testing

Lots of shoving spirits into and out of possessed items and using them in various ways.
Purified and corrupted a soulstone with their respective methods.
Took a body into the soulstone and made a construct.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Soulstones can now create possessed items by using an occupied soulstone on (almost) any item.
add: When a possessed item created from a soulstone dies, it will revert to being a shade, as if it had been released from the soulstone directly.
tweak: Certain possessed items can now read, and a few can write as well.
add: Pressing your "use held item" keybind while a possessed item will use the item.
add: Committing suicide with a soul stone stuffs you into it.
add: Using an empty soul stone in hand will give a custom suicide prompt.
tweak: The chaplain's mysterious old shard is no longer single-use.
fix: Many possessed item bugs have been fixed.
/:cl:

@FunnyMan3595 FunnyMan3595 added the Feature This PR is a new addition to the game label Jan 15, 2025
@FunnyMan3595
Copy link
Contributor Author

Ah, dang, forgot I needed to migrate the other two attack chain methods, will do that soonish.

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 15, 2025
@FunnyMan3595
Copy link
Contributor Author

There we go, migrated and tested.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 16, 2025
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 16, 2025
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Feature This PR is a new addition to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants