Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigger air pumps #27894

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Bigger air pumps #27894

merged 5 commits into from
Jan 15, 2025

Conversation

FunnyMan3595
Copy link
Contributor

What Does This PR Do

Adds large and bluespace versions of the air pump, holding 5x and 25x the volume.
Increases the max pressure of air pumps to 45 atm, matching a canister.
Air pumps now start filled with air.
The Engineering ERT storage room has been expanded and reorganized to include bluespace air pumps.

Why It's Good For The Game

With MILLA 2, large-scale breaches tend to drain air from large portions of the station. Buffing air pumps and giving a really high-capacity one to ERTs will help a lot with refilling rooms after large breaches.

Images of changes

image

2025-01-08.03-09-51.mp4

Testing

Pumped air in and out of all three pumps and activated a scrubber.
Connected all three pumps and a scrubber to tank and connector.
Inspected the updated CC area both as a ghost and an NNO.
Checked that all four engineering door buttons worked.
Bought, sold, and ran an empty round trip with the cargo shuttle (since its CC location moved).


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Large and bluespace versions of the portable air pump. They are not available on station.
tweak: Air pumps can now reach up to 45 atm, up from 10 and matching a canister.
tweak: Air pumps now start filled to capacity with air.
tweak: Engineering ERT storage area has been expanded, uses shelving, and has several bluespace portable air pumps for all your refilling needs.
/:cl:

@FunnyMan3595 FunnyMan3595 added Feature This PR is a new addition to the game Map Edit This PR will modify a map Sprites This PR modifies the game sprites labels Jan 8, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 8, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jan 8, 2025
Copy link
Contributor

@Christasmurf Christasmurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprites LGTM

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 12, 2025
@SynthTwo
Copy link
Contributor

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Jan 14, 2025
@Burzah Burzah added this pull request to the merge queue Jan 15, 2025
Merged via the queue into ParadiseSS13:master with commit 39fa268 Jan 15, 2025
17 checks passed
@FunnyMan3595 FunnyMan3595 mentioned this pull request Jan 15, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Feature This PR is a new addition to the game Map Edit This PR will modify a map Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants