Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You cannot put items into toolboxes without first picking up the toolbox #27876

Open
1 task done
Fordoxia opened this issue Jan 8, 2025 · 6 comments
Open
1 task done

Comments

@Fordoxia
Copy link
Contributor

Fordoxia commented Jan 8, 2025

Exploit Reports

  • I confirm this issue is not an exploit. (Required)

BYOND Version

N/A

Issue Description

You used to be able to put items into toolboxes that were next to you, without picking them up.

You can't do that anymore.

What did you expect to happen?

To put an item into the toolbox on the table next to me.

What happened instead?

It refused to accept the item until I had it in my hand.

Why is this bad/What are the consequences?

This is annoying, as it turns out that putting stuff into a toolbox I'm not using is a thing I do more often than I thought I would.

Steps to reproduce the issue.

Have toolbox next to you.
Try to put item inside.

When did the problem start happening?

Noticed today.

Extra information

This is probably an attack chain migration thing.

Relevant log output/runtime error

@HMBGERDO
Copy link
Contributor

HMBGERDO commented Jan 8, 2025

Are you sure you tried to put an item in the toolbox on help intent? If the intent is not help, you will be unable to put items in storages that are not on you(backpack, as an example)
This was changed in QOL fix for combat mostly as you shouldnt put your baton in the toolbox while chasing someone

@HMBGERDO
Copy link
Contributor

HMBGERDO commented Jan 8, 2025

here, that PR tweaked that #21946

@Fordoxia
Copy link
Contributor Author

Are you sure you tried to put an item in the toolbox on help intent? If the intent is not help, you will be unable to put items in storages that are not on you(backpack, as an example) This was changed in QOL fix for combat mostly as you shouldnt put your baton in the toolbox while chasing someone

Yes, this was when I was doing testing for my Theta PR (I did a full run as part of it), no reason to even touch intents before starting to clear out science. I just noticed this when I was using the old blue toolbox.

@Erikos66
Copy link
Contributor

Erikos66 commented Jan 15, 2025

Can I ask what item it was?

Having tested this on and off tables. I can add to the contents of the toolbox just fine.

@Scribble-Sheep
Copy link
Contributor

Scribble-Sheep commented Jan 16, 2025

This is also affecting first-aid kits. Tried to add a health scanner to one that was on the floor just now in a test server.
Doesn't even let you do it if you alt click it and place it in the inventory yourself.

@HMBGERDO
Copy link
Contributor

i re-tested it, it works as intended
https://youtu.be/LUoCrKlmsiw

Can you possibly record your game while doing that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants