Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Deltastation's Huge Atmospherics Power Draw #27671

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

haydenredacted
Copy link
Contributor

@haydenredacted haydenredacted commented Dec 18, 2024

What Does This PR Do

Fixes the extreme amount of power that deltastation's atmos eats. This was done by turning off the heaters by default and making the Atmospherics desk its own new area.
The Atmospherics Desk is now Atmospherics Canister Storage and has an APC now.

Why It's Good For The Game

Atmospherics eating a lot of power is unnecessary and seeing the draw be upwards of 22k is a tad too much.

Images of changes

image
image

Testing

Booted up test server, power draw was in the understandable range, close to the bridge and medbay's. Atmospheric's Cannister Storage APC, airlock, and air alarm all had correct names.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: fixed deltastation's power draw by turning off heaters and adding a new area
/:cl:

@haydenredacted haydenredacted changed the title Fixes Deltastation's Huge Power Draw Fixes Deltastation's Huge Atmospherics Power Draw Dec 18, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 18, 2024
code/game/area/ss13_areas/engineering_areas.dm Outdated Show resolved Hide resolved
code/game/area/ss13_areas/engineering_areas.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Dec 30, 2024
Copy link
Contributor

@FunnyMan3595 FunnyMan3595 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We already have /area/station/engineering/atmos/control, which is what should be used here. No need for a new area type.
  2. Please don't reroute the pipe in the same PR; that's unrelated.

@Fordoxia
Copy link
Contributor

Fordoxia commented Jan 6, 2025

  1. We already have /area/station/engineering/atmos/control, which is what should be used here. No need for a new area type.
  2. Please don't reroute the pipe in the same PR; that's unrelated.

The pipe would go under the wall that got added to hold the new APC if not rerouted.

The curve needs to be moved, though, as the yellow and cyan pipes are overlapping and that's probably bad.

@Burzah Burzah requested a review from FunnyMan3595 January 16, 2025 18:11
@FunnyMan3595
Copy link
Contributor

The pipe would go under the wall that got added to hold the new APC if not rerouted.

I see your point on that one, but you should still switch to /area/station/engineering/atmos/control over making a new area type.

@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 17, 2025
@silverplatedelta
Copy link
Contributor

In the attached screenshot, it appears that you have two pipes on the same layer mapped over each other, this will result in horrible awful pain and suffering as distro connects to that waste line. Can you make it so the pipes are not overlapping like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Map Edit This PR will modify a map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants