Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprites the Hand Tele #27550

Closed
wants to merge 5 commits into from
Closed

Conversation

ExusA
Copy link
Contributor

@ExusA ExusA commented Dec 5, 2024

What Does This PR Do

Updates the sprite for the Hand Tele. Here's an explanation of the new design:
The hand tele works by carefully applying electric pulses to a big bluespace crystal. It only has one slider and two buttons to adjust your destination, since the hand tele only lets you pick a few options from a list.
The buttons would scroll through possible destinations, and you would pull the slider to generate a portal.

Why It's Good For The Game

The hand tele sprite is really old and could use a refresh.

Images of changes

Normal:
Hand Tele
EMP:
Hand Tele EMP
Old:
Old Handtele

Edit,
The design has been changed to this as per feedback:
Hand Tele EMP
Hand Tele

Edit,
The design has been changed a second time at request:
Hand Tele 2 EMP
Hand Tele 2 Idle
Hand Tele 2

Testing

Compiled and looked at the hand tele in game.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
imageadd: Resprited the hand tele.
/:cl:

Updates the Hand Tele sprite.
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Dec 5, 2024
@ExusA
Copy link
Contributor Author

ExusA commented Dec 5, 2024

Also, I removed some unused detective scanner icons from device.dmi since I was working on it. They're old codersprites that we won't be able to repurpose for anything else, so I hope it's alright for the sake of cleaning things up.
oldscanner2-export
oldscanner-export

@1080pCat 1080pCat added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Dec 5, 2024
@1080pCat
Copy link
Contributor

1080pCat commented Dec 5, 2024

Not the biggest fan of this respite tbh. It kinda looks like a toy more than a prototype hightech item.
i will say, that i like that the EMP state is more clear. Though the wire being broken is a little odd

@ExusA
Copy link
Contributor Author

ExusA commented Dec 5, 2024

After discussing it in spriting, here's a new design that resolves some of the issues with the old one. It's made of plastitanium this time, has a more sensible grip, and has a wire panel coming out the side.
Hand Tele EMP
Hand Tele

ExusA added 2 commits December 5, 2024 22:46
Made some changes to the hand tele according to feedback.
Fixes a change in animation delay
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 5, 2024
@ExusA ExusA marked this pull request as draft December 7, 2024 17:23
@ExusA
Copy link
Contributor Author

ExusA commented Dec 7, 2024

Drafted pending requested changes.

Converts the hand tele to an alternate perspective on request
@ExusA
Copy link
Contributor Author

ExusA commented Dec 7, 2024

I've redone the sprite again on request. These are the new sprites:

Idle:
Hand Tele 2 Idle
EMP:
Hand Tele 2 EMP
On opening the destination menu:
Hand Tele 2

@ExusA ExusA marked this pull request as ready for review December 7, 2024 18:10
@ExusA ExusA marked this pull request as draft December 7, 2024 18:29
@ExusA
Copy link
Contributor Author

ExusA commented Dec 7, 2024

Redrafting this until I'm able to nail down a perspective and look that's consistent with other new ingame items.

@ExusA
Copy link
Contributor Author

ExusA commented Dec 8, 2024

Alright, thanks everyone who's taken the time to consider this PR.
I'm going to close it for the time being, because I don't feel the shading and styling is in line with what the server is aiming to produce, and I don't want to try push for badly-fitting sprites to go in the game.

I'll open a new PR if I'm able to produce something closer to the current direction, but by all means if anybody ends up respriting the hand tele in the interim, I'm satisfied the wasted effort will have been a good learning excersise and I wouldn't mind.

@ExusA ExusA closed this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants