Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customized welding helmets to the loadout #27528

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

m-dzianishchyts
Copy link
Contributor

@m-dzianishchyts m-dzianishchyts commented Dec 3, 2024

What Does This PR Do

Adds customized welding helmets to the loadout.

Why It's Good For The Game

I was surprised to notice these helmets. They don't seem to be found anywhere, so adding to the loadout seems appropriate.

Images of changes

image

Testing

Started with a nice helmet in a backpack.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑 Maxiemar
tweak: Customized welding helmets are available in the loadout now.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 3, 2024
@Fordoxia
Copy link
Contributor

Fordoxia commented Dec 3, 2024

It would also make sense for roboticists to have access to these, they do welding too.

@Adrer
Copy link
Contributor

Adrer commented Dec 4, 2024

Do these have on-character icons?

@m-dzianishchyts
Copy link
Contributor Author

Do these have on-character icons?

All of them have general on-character icons

image

Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One or More of these may be donor/fluff items, in which case they will likely need to be removed. Dev team is currently looking into it. If they are donor/fluff items, someone will need to remove them from the CC z-level.

@Contrabang Contrabang added the Do Not Merge This PR must not be merged or closed label Dec 5, 2024
@DGamerL
Copy link
Member

DGamerL commented Dec 7, 2024

As communicated over discord, only the red one is an active donor item, the other two are good to go!

@Contrabang Contrabang removed the Do Not Merge This PR must not be merged or closed label Dec 7, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Dec 21, 2024
@DGamerL DGamerL added this pull request to the merge queue Jan 1, 2025
Merged via the queue into ParadiseSS13:master with commit d6259d9 Jan 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants