Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gives hivemind to clings as default again #27480

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Gives hivemind to clings as default again #27480

merged 1 commit into from
Dec 17, 2024
+5 −10

Conversation

DGamerL
Copy link
Member

@DGamerL DGamerL commented Nov 29, 2024

What Does This PR Do

Makes hivemind a default power changelings have again
Partial revert of #20375

Why It's Good For The Game

With the removal of the changelings gamemode (thank god) the amount of changelings possible in a round has drastically gone down, to at most 3 or 4 during highpop.
With this, it should be fine again to give them hivemind, as the teaming should be minimal.

Images of changes

image
image

Testing

See above
No runtimes when being made a changeling and when the datum is removed

Declaration

image

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Changelings have their hivemind as a base ability again now
/:cl:

@DGamerL DGamerL added the Balance This PR will modify how effective something is or isnt label Nov 29, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Nov 29, 2024
@autocephalophagy
Copy link

Will lings still be able to share DNA or will that be a separate power now?

@DGamerL
Copy link
Member Author

DGamerL commented Nov 30, 2024

Still a thing

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting review This PR is awaiting review from the review team labels Nov 30, 2024
@Coolrune206
Copy link
Contributor

If you're going to try to revert this, also revert starting DNA being protected, which was a buff given in the original PR to account for the loss of DNA-upload.

@DGamerL
Copy link
Member Author

DGamerL commented Dec 2, 2024

If you're going to try to revert this, also revert starting DNA being protected, which was a buff given in the original PR to account for the loss of DNA-upload.

Being able to lose your starting DNA is just annoying though, if balance wants it I can do that but I don't think it's a good change to revert

@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Requested This PR has a pending testmerge request label Dec 4, 2024
chuga-git
chuga-git approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@chuga-git chuga-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@Coolrune206
Copy link
Contributor

If you're going to try to revert this, also revert starting DNA being protected, which was a buff given in the original PR to account for the loss of DNA-upload.

Being able to lose your starting DNA is just annoying though, if balance wants it I can do that but I don't think it's a good change to revert

Motivating clings to shift identity is good. It's the entire idea of the antag.

@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Active This PR is currently testmerged on production -Status: Awaiting merge This PR is ready for merge and removed Testmerge Requested This PR has a pending testmerge request -Status: Awaiting approval This PR is waiting for approval internally labels Dec 6, 2024
@Burzah Burzah added this pull request to the merge queue Dec 17, 2024
Merged via the queue into ParadiseSS13:master with commit 3fb4c7f Dec 17, 2024
12 checks passed
dj-34 added a commit to ss220club/Paradise-SS220 that referenced this pull request Dec 18, 2024
@dj-34
Merge Upstream 17.12.2024 (#1702)
4daee8e 
This pull request merges upstream/master. Resolve possible conflicts
manually and make sure all the changes are applied correctly.

> [!NOTE]
> Requires Wiki Update:
> ParadiseSS13#27385
> ParadiseSS13#27603

## Changelog
:cl: ParadiseSS13
tweak: Изменен бонус SM Crush, дабы зависеть от EER, количества каждого
газа в камере. <!-- tweak: Changed the SM crush bonus to depend on EER,
the amount of each gas in the chamber.
(ParadiseSS13#27168) -->
tweak: Добавлено количество молей и газовый коэффициент газовой смеси в
камере, а также количество молей каждого газа в консоли мониторинга
Суперматерии. <!-- tweak: Adds the mole count and gas coefficient of the
gas mix in the chamber as well as the mole count of each gas to the
supermatter monitoring console
(ParadiseSS13#27168) -->
tweak: Радиационный костюм стал лучше, что позволило ему быть легче, не
жертвуя защитой. <!-- tweak: The radiation suit has gotten better
shielding, allowing it to be lighter, without sacrificing protection
(ParadiseSS13#27570) -->
tweak: СМ теперь только прекращает вывод тепла, вместо охлаждения газа.
<!-- tweak: SM now only stops outputting heat, rather than cooling gas
down. (ParadiseSS13#27492) -->
fix: Вы больше не можете реролльнуть цели на людей, которые ушли в крио.
<!-- fix: You can no longer re-roll objectives onto people that just
cryo'd. (ParadiseSS13#27635) -->
add: Добавляет консоль для двигателя Сингулярности, который контролирует
полевые генераторы, размер и уровень энергии, а также предупреждает
станцию, если нарушено содержание. <!-- add: Adds a console for the
singularity engine which monitors field generators and the singularity's
size and energy level as well as alerting the station once containment
had failed. (ParadiseSS13#27361) -->
tweak: Добавляет плату монитора Сингулярности в саплай-пак двигателя
Сингулярности. <!-- tweak: Adds a singularity monitor board to the
singularity engine supply pack
(ParadiseSS13#27361) -->
tweak: Убрано ограничение на радиационный импульс Сингулярности. <!--
tweak: Removed the hardcap on the singularity's radiation pulse
(ParadiseSS13#27361) -->
tweak: Волны излучения, порождаемые Сингулярностью, начинают распадаться
только после того, как исчезает содержащее ее энергетическое поле. <!--
tweak: The radiation waves produced by the singularity start decaying
only after the energy field containing it.
(ParadiseSS13#27361) -->
tweak: Добавляет параметр радиуса в конструктор волны излучения и
процедуру radiation_pulse(), который заставляет волну излучения затухать
не в центре, а на расстоянии от внешних границ источника излучения,
состоящего из нескольких тайлов. <!-- tweak: Добавляет параметр радиуса
в конструктор волны излучения и процедуру radiation_pulse(), который
заставляет волну излучения затухать не в центре, а на расстоянии от
внешних границ источника излучения, состоящего из нескольких тайлов.
(ParadiseSS13#27361) -->
fix: Singulo Shop Fort для призраков теперь находится на 5-м уровне, а
не 4. <!-- fix: Singulo loose alert for ghosts is now at level 5 rather
than 4. (ParadiseSS13#27361) -->
fix: Маскировка применяемая на себя теперь скрывает ваш security HUD.
<!-- fix: Disguise self now hides your security HUD.
(ParadiseSS13#27533) -->
fix: Исправлено поведение, при котором лампочки можно было вставлять в
floor lights бесконечное число раз. <!-- fix: Behavior where light bulbs
could be inserted an infinite number of times into light floors has been
fixed. (ParadiseSS13#27548) -->
fix: Теперь все сообщения факсов, сообщения ЦК, сообщения Синди, запросы
ERT и запросы кода ядерной аутентификации отображаются в разделе Admin
PM. <!-- fix: Fax messages, centcomm messages, syndicate requests, ert
requests, and nuke code requests all show up in the ADMIN PM section now
(ParadiseSS13#27614) -->
fix: Уведомление призракам и опросы теперь показываются на вкладке
Deadchat. <!-- fix: Notifying ghosts and polling ghosts now shows in the
deadchat tab now (ParadiseSS13#27614)
-->
fix: Снег на земле больше не скрывает тени. <!-- fix: Snow on the ground
no longer hides shadows
(ParadiseSS13#27615) -->
fix: ERT больше не появляются как антаги в некоторых случаях. <!-- fix:
ERT no longer appear as antags in some cases
(ParadiseSS13#27545) -->
fix: Исправлены 2 активные руки, в некоторых случаях. <!-- fix: Fixed
some of the cases where you would have 2 active hands (hopefully?)
(ParadiseSS13#27652) -->
fix: MMI's больше не становятся невидимыми, когда они умирают. <!-- fix:
MMIs don't become invisible anymore when they die
(ParadiseSS13#27603) -->
fix: Кошельки теперь правильно вставляют идентификационные карты,
используя кошелек на карте. <!-- fix: Wallets now correctly insert ID
cards by using the wallet on the card.
(ParadiseSS13#27655) -->
fix: Талисман Бессмертия больше не падает бесконечно в чазмы и не
является невидимым, и теперь должным образом выходит из чазмов. <!--
fix: Immortality Talisman's no longer fall into chasms endlessly and
being invisible, and now properly get spit out of chasms.
(ParadiseSS13#27515) -->
tweak: Проведя 2 года, зализывая раны после столкновений с
исследователями, офицеры синдиката и КМ научились парировать, используя
свои знания CQC. Квартермейстер депо бросил курить и теперь стал более
выносливым. <!-- tweak: After spending 2 years licking their wounds from
explorers encounters, syndicate officers and QM learned to parry using
their CQC knowledge. Depot Quartermaster quit smoking and now is more
tough. (ParadiseSS13#27399) -->
tweak: Генокрады теперь снова имеют хайвмайнд в качестве своей базовой
способности. <!-- tweak: Changelings have their hivemind as a base
ability again now (ParadiseSS13#27480)
-->
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverplatedelta silverplatedelta silverplatedelta approved these changes

@Burzah Burzah Burzah approved these changes

@chuga-git chuga-git chuga-git approved these changes

Assignees
No one assigned
Labels
-Status: Awaiting merge This PR is ready for merge Balance This PR will modify how effective something is or isnt Testmerge Active This PR is currently testmerged on production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DGamerL @autocephalophagy @Coolrune206 @chuga-git @Burzah @silverplatedelta @ParadiseSS13-Bot