Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paradise Station: Episode V - The Laserslug Strikes Back #27457

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

SchrodingersWolf
Copy link
Contributor

What Does This PR Do

Readds Laser Slugs that were removed in #19552 - These are shotgun shells that fires one 20 damage laser beam per shell, much like a normal laser gun.

They are also now printable in a hacked Autolathe as well, and uses the currently unused improvised shell sprite to denote their somewhat hacky nature.

Why It's Good For The Game

The improvised weapon category has been quite lacking and stagnant ever since the removal of improvised shells and overloaded improvised shell - While they are indeed problematic for balance, now shotguns mostly have nonlethal ammunition or techshells, with the latter requires Science to be manned, the Scientist on duty to understand what you are asking for, and also a lengthy crafting process. Incendiary slugs are okay but are difficult to use, so they are very underutilized.

Laser slugs would fill the niche that was previous occupied by improv shells, but without the associated issues with brute damage - So no bone breaks or internal bleeding. Critical burns are less debilitating so I wouldn't be too worried about that either.

And Qwerty has expressed a desire for laser muskets as well - This is in my opinion a good stopgap measure for now.

I'm also open to changing these too - Either by adding a misfire chance or lowering the damage if it becomes way too powerful, but I have been assured by many that it wouldn't overshadow other options so let's see how it goes.

Images of changes

Images to come

Testing

It really shouldn't break anything, but I'll test it tonight.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.
    image

Changelog

🆑
add: Readds Laser Slugs and make them printable in hacked autolathes.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Nov 25, 2024
@1080pCat
Copy link
Contributor

worried about combat shotguns and this, lots of burst damage they can just have without rnd now

@SchrodingersWolf
Copy link
Contributor Author

worried about combat shotguns and this, lots of burst damage they can just have without rnd now

Do note that combat shotgun fires as quickly as a normal laser gun, so it isn't as much burst damage as you think

Copy link
Contributor

@silverplatedelta silverplatedelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! No balance objections either.

@silverplatedelta silverplatedelta added the Feature This PR is a new addition to the game label Nov 27, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 29, 2024
@SynthTwo
Copy link
Contributor

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Nov 29, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Nov 30, 2024
Copy link
Contributor

@BiancaWilkson BiancaWilkson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, confirmed with the author that it was sufficiently tested.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Dec 3, 2024
@Burzah
Copy link
Member

Burzah commented Dec 6, 2024

Looks good! Make sure to update your testing after you have completed it, in the future.

@Burzah Burzah added this pull request to the merge queue Dec 6, 2024
Merged via the queue into ParadiseSS13:master with commit ab0627b Dec 6, 2024
12 checks passed
Legendaxe added a commit to ss220club/Paradise-SS220 that referenced this pull request Dec 11, 2024
This pull request merges upstream/master. Resolve possible conflicts
manually and make sure all the changes are applied correctly.

> [!NOTE]
> Requires Wiki Update:
> ParadiseSS13#27371
> ParadiseSS13#27457
> ParadiseSS13#27465
> ParadiseSS13#27472
> ParadiseSS13#27506

## Changelog
:cl: ParadiseSS13
add: Включение силового поглотителя теперь будет предлагать гостам
следить за ним. Тоже самое при его взрыве. <!-- add: Turning on a
powersink will now ping ghosts with a prompt to follow the powersink. As
with when its about to explode
(ParadiseSS13#27349) -->
fix: Слаймомены снова могут выбрать тип крови на карте агента. <!-- fix:
Slimepeople can pick a bloodtype again on agent IDs.
(ParadiseSS13#27509) -->
fix: Сброс карты агента больше не вызывает неизменяемость типа крови.
<!-- fix: Resetting an agent ID no longer causes bloodtype to be
unchangable. (ParadiseSS13#27509) -->
del: Удален EXPERIMENTOR. <!-- del: Removed EXPERIMENTOR
(ParadiseSS13#27472) -->
tweak: Деструктивный анализатор переименован в научный анализатор. <!--
tweak: Destructive analyser is now scientific analyser
(ParadiseSS13#27472) -->
tweak: Странные объекты теперь могут быть просканированы в научном
анализаторе. <!-- tweak: Strange objects can now be discovered in the
scientific analyser
(ParadiseSS13#27472) -->
fix: На плате шлюза снова можно изменить доступ. <!-- fix: Destroyed
airlock electronics should now properly prevent players from setting
their access. (ParadiseSS13#27538) -->
tweak: Arc Revolver имеет еще 2 выстрела. <!-- tweak: Arc revolver has 2
more shots. (ParadiseSS13#27476) -->
tweak: Стрельба и прицеливание с LWAP теперь быстрее. Снаряды теперь
попадают по ползающим мобам и пролетают через паутину и балки. <!--
tweak: Lwap fires and scopes faster, always hits crawlers, and shoots
through spider webs / girders now.
(ParadiseSS13#27476) -->
tweak: Урон BSG значительно увеличен. <!-- tweak: BSG AOE damage greatly
improved (ParadiseSS13#27476) -->
fix: Исправлено отсутствие анимации атаки у некоторых предметов. <!--
fix: Some items missing an attack animation have been fixed.
(ParadiseSS13#27554) -->
fix: Отвертки теперь перерабатываются в автолате в харм интенте. <!--
fix: Screwdrivers are properly recycled in autolathes on harm intent.
(ParadiseSS13#27557) -->
fix: Было исправлено несколько побочных эффектов атаки. <!-- fix:
Several unexpected attack side-effects, including borgs bludgeoning
themselves with goliath hide plates, have been fixed.
(ParadiseSS13#27542) -->
add: Лазерные слаги добавлены во взломанный автолат. <!-- add: Readds
Laser Slugs and make them printable in hacked autolathes.
(ParadiseSS13#27457) -->
add: Добавлен апгрейд сервисного борга. <!-- add: Adds the Executive
Service cyborg Upgrade
(ParadiseSS13#27371) -->
add: Добавлено четыре новых сыра и банка икры. <!-- add: Adds four new
cheeses and caviar (ParadiseSS13#27371)
-->
imageadd: Старый сыр получил новый спрайт. <!-- imageadd: Resprites
cheese (ParadiseSS13#27371) -->
fix: Бипски и другие боты СБ больше не выбивают дерьмо из экипажа так
болезненно. <!-- fix: Beepsky and other secbots are no longer loose
cannons that beat the shit out of suspects.
(ParadiseSS13#27553) -->
fix: Прием целых пузырьков с таблетками снова работает. <!-- fix:
Swallowing entire bottles of pills works as intended again.
(ParadiseSS13#27553) -->
fix: Поедание внутренних органов снова работает. <!-- fix: Eating
internal organs works as intended.
(ParadiseSS13#27553) -->
fix: Исправлены проблемы с атакой саблей. <!-- fix: Issues with saber
slaps and attacks are fixed.
(ParadiseSS13#27553) -->
fix: Исправлена ​​возможность красить простыни. <!-- fix: Fixed the
ability to dye bedsheets.
(ParadiseSS13#27569) -->
fix: Борги снова имеют возможность достать плату из шлюза. <!-- fix:
Borgs should now be able to pick up airlock electronics again.
(ParadiseSS13#27571) -->
fix: Зелья снова можно скармливать слаймам с помощью консоли ксено. <!--
fix: Slime management console can feed slime potions again
(ParadiseSS13#27576) -->
imageadd: Спрайт костюма охотника на ведьм был обновлен. <!-- tweak:
Resprited and Vox Refit Witchhunter Chaplain outfits
(ParadiseSS13#27539) -->
tweak: Экраны теперь светятся немного ярче и в соответствующем цвете.
<!-- tweak: Computer screens now glow slightly brighter and in an
appropriate color. (ParadiseSS13#27484)
-->
tweak: Магма-эль и космическое пиво теперь ведут себя как бутылки. <!--
tweak: Magma-ale and space beer are now bottles
(ParadiseSS13#27407) -->
tweak: Бутылки магма-эля и космического пива теперь вмещают 50 юнитов.
<!-- tweak: Magma-ale and space beer bottles now hold 50u
(ParadiseSS13#27407) -->
fix: Яйца ксеноморфов теперь развиваются правильно. <!-- fix: Alien eggs
evolve correctly now.
(ParadiseSS13#27537) -->
tweak: Добавлена ​​фигурка CMO во взломанный автомат медицинской одежды.
<!-- tweak: added CMO's figurine to the medical clothing vendor if it is
hacked. (ParadiseSS13#27506) -->
add: Добавлены латунные скамьи, шлюзы, полки, оружейные стойки и слипер.
<!-- add: Adds Brass Pews, Pinion Airlocks, Brass Shelves, Brass
Gunrack, Brass Sleeper.
(ParadiseSS13#27465) -->
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Feature This PR is a new addition to the game Requires Wiki Update Useful for Wiki Contributers to search for things that need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants