Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates the hand labeler to the new attack chain #27400

Merged
merged 11 commits into from
Jan 16, 2025

Conversation

Toastical
Copy link
Contributor

@Toastical Toastical commented Nov 19, 2024

What Does This PR Do

Fixes #27356
Migrates the hand labeler to the new attack chain
Adds a QoL examine for the state of the labeler (remaining labels and label text)
Allows you to put the labeler in a backpack if there's no label
Special thanks to @DGamerL, @Adrer for helping out with signals and the old attack chain and to @warriorstar-orion for help with the new attack chain!

Why It's Good For The Game

New attack chain gooderer. Bug bad.

Testing


  • Tried labeling from afar
  • Tried labeling with no text
  • Tried labeling with invalid text
  • Tried labeling with too much text
  • Tried labeling a mob
  • Labeled an item
  • Unlabeled an item
  • Overwrote a label
  • Registered my ID to the labeler
  • Labeled a crate as a personal goal
  • Refilled a labeler
  • Removed a label from a backpack
  • Put labeler in an unlabeled backpack

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Hand labeler can unlabel items again.
fix: You can put a hand labeler in an unlabeled backpack now
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Nov 20, 2024
@Toastical Toastical requested a review from DGamerL November 20, 2024 11:07
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Nov 21, 2024
@1080pCat 1080pCat added the Fix This PR will fix an issue in the game label Nov 22, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Nov 22, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 22, 2024
@Toastical Toastical closed this Nov 23, 2024
@Toastical Toastical reopened this Nov 23, 2024
@silverplatedelta
Copy link
Contributor

this will also fix #20529

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Dec 2, 2024
@DGamerL DGamerL removed the request for review from AffectedArc07 December 3, 2024 16:52
@Toastical Toastical changed the title Fix: The hand labeler can unlabel items again Migrates the hand labeler to the new attack chain Dec 3, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the Map Edit This PR will modify a map label Dec 3, 2024
@Toastical Toastical marked this pull request as draft December 3, 2024 17:00
@Toastical Toastical marked this pull request as ready for review December 3, 2024 23:42
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Dec 4, 2024
@Toastical Toastical requested a review from lewcc December 18, 2024 14:36
Copy link
Contributor

@FunnyMan3595 FunnyMan3595 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but I'd like to confirm what happens with storages (e.g. backpacks). This is slightly busted before this PR:

  • When on, sets a label on the storage.
  • When off, goes into the storage.

Ideally, we'd want it to do:

  • When on, sets a label on the storage.
  • When off and storage has a label, remove the label.
  • When off an storage does not have a label, goes into the storage.

@Contrabang Contrabang removed the Map Edit This PR will modify a map label Jan 8, 2025
@Burzah Burzah dismissed SteelSlayer’s stale review January 10, 2025 20:30

Requested changes made.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 10, 2025
@Toastical Toastical requested a review from DGamerL January 10, 2025 23:58
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting merge This PR is ready for merge labels Jan 11, 2025
@Burzah Burzah dismissed DGamerL’s stale review January 16, 2025 18:03

Requested changes made.

@Burzah Burzah added this pull request to the merge queue Jan 16, 2025
Merged via the queue into ParadiseSS13:master with commit 166b1d5 Jan 16, 2025
17 checks passed
@Toastical Toastical deleted the handlabeler branch January 16, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hand Labelers can't Un-Label