-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrates the hand labeler to the new attack chain #27400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGamerL
requested changes
Nov 20, 2024
DGamerL
reviewed
Nov 20, 2024
SteelSlayer
previously requested changes
Nov 22, 2024
this will also fix #20529 |
06ce403
to
053122c
Compare
lewcc
reviewed
Dec 17, 2024
Burzah
approved these changes
Dec 26, 2024
FunnyMan3595
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but I'd like to confirm what happens with storages (e.g. backpacks). This is slightly busted before this PR:
- When on, sets a label on the storage.
- When off, goes into the storage.
Ideally, we'd want it to do:
- When on, sets a label on the storage.
- When off and storage has a label, remove the label.
- When off an storage does not have a label, goes into the storage.
FunnyMan3595
approved these changes
Jan 6, 2025
lewcc
approved these changes
Jan 6, 2025
warriorstar-orion
approved these changes
Jan 10, 2025
Burzah
approved these changes
Jan 10, 2025
DGamerL
previously requested changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-Status: Awaiting review
This PR is awaiting review from the review team
Fix
This PR will fix an issue in the game
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Fixes #27356
Migrates the hand labeler to the new attack chain
Adds a QoL examine for the state of the labeler (remaining labels and label text)
Allows you to put the labeler in a backpack if there's no label
Special thanks to @DGamerL, @Adrer for helping out with signals and the old attack chain and to @warriorstar-orion for help with the new attack chain!
Why It's Good For The Game
New attack chain gooderer. Bug bad.
Testing
Declaration
Changelog
🆑
fix: Hand labeler can unlabel items again.
fix: You can put a hand labeler in an unlabeled backpack now
/:cl: