Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallening 2: The attack of the girders [MDB IGNORE][IDB IGNORE] #27001

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

DGamerL
Copy link
Member

@DGamerL DGamerL commented Oct 6, 2024

Why It's Good For The Game

Our walls are very old, and these go more hand-in-hand with our current sprite perspective.

TODO:

  • False wall animations
  • False wall states
  • Mineral walls
  • Cult walls
  • Reinforced wall build steps

Images of changes

These images were taken at different stages of development, some may have unreplaced sprites
image

image

image

image

image


Changelog

🆑 Christasmurf, DGamerL, McRamon
imageadd: Walls have been fully resprited
/:cl:

@Contrabang Contrabang marked this pull request as draft October 6, 2024 23:29
@Christasmurf
Copy link
Contributor

Also need to do build steps for reinforced walls, and girders

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Oct 6, 2024
@lewcc lewcc added Sprites This PR modifies the game sprites Requires Wiki Update Useful for Wiki Contributers to search for things that need updating labels Oct 6, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Oct 7, 2024
@Coolrune206
Copy link
Contributor

Surprising myself saying this, but I actually quite like it. The biggest standout for me at the moment though is airlocks, will they be changed at some-point-in-the-futureTM to match the walls and connect with them, or are there presently no plans for that?

@DGamerL
Copy link
Member Author

DGamerL commented Oct 7, 2024

Surprising myself saying this, but I actually quite like it. The biggest standout for me at the moment though is airlocks, will they be changed at some-point-in-the-futureTM to match the walls and connect with them, or are there presently no plans for that?

Yes, we're gonna do all of those in a different PR later

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Oct 8, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Requested This PR has a pending testmerge request label Oct 9, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Oct 10, 2024
@DGamerL DGamerL changed the title Wallening [MDB IGNORE] Wallening [MDB IGNORE][IDB IGNORE] Oct 14, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting review This PR is awaiting review from the review team labels Oct 14, 2024
@TravisAngeI
Copy link

TravisAngeI commented Oct 26, 2024

Wall sprites look objectively really good, but I don't feel like they mesh well with how the rest of the current station tiles/objects look? I guess what I'm trying to say is they look too different to me. Won't complain or anything if this gets merged, just kinda wanted to point this out. (I don't really expect anyone to understand what I'm getting at here)

image

image

@DGamerL
Copy link
Member Author

DGamerL commented Oct 27, 2024

Those are all things that we plan on changing when this PR is merged @TravisAngeI

@DGamerL DGamerL changed the title Wallening [MDB IGNORE][IDB IGNORE] Wallening 2: The girder strikes back [MDB IGNORE][IDB IGNORE] Dec 5, 2024
@DGamerL DGamerL changed the title Wallening 2: The girder strikes back [MDB IGNORE][IDB IGNORE] Wallening 2: The attack of the girders [MDB IGNORE][IDB IGNORE] Dec 5, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Jan 16, 2025
@Contrabang
Copy link
Contributor

Contrabang commented Jan 16, 2025

I think the walls look good, but they're VERY jarring when mixed with current wall decorations and floors. The doors are also a minor problem, but we could port something like bay doors IDK.

Issues

Window damage stations probably need to be updated
image

Something feels very wrong with how windows overlap themselves
image
image
image
image
image

Weird layering issue leads to this with windows and shutters
image

Sometimes, walls after an explosion happens near them fail to properly re-merge with windows (happens on master too, but is way more noticable here)
image

@ParadiseSS13-Bot ParadiseSS13-Bot removed the Testmerge Active This PR is currently testmerged on production label Jan 16, 2025
@Toastical
Copy link
Contributor

Toastical commented Jan 16, 2025

Aside of stuff yet to be resprited (eg wallbumps, doors), the cylindrical bits of reinforced glass stick out to me, singlet walls/windows and girders look weird.

@Alecksohs
Copy link
Contributor

Alecksohs commented Jan 17, 2025

I think the walls look good, but they're VERY jarring when mixed with current wall decorations and floors. The doors are also a minor problem, but we could port something like bay doors IDK.

My floors are near ready to go and possibly can be a sister PR in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites Testmerge Requested This PR has a pending testmerge request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

9 participants