Fixes saber spelling #26766
Merged
Fixes saber spelling #26766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
|
this is anti-American discrimination! 🇺🇸 |
Burzah
added
Fix
Burzah
approved these changes
Sep 17, 2024
ParadiseSS13-Bot
added
-Status: Awaiting merge
|
!wiki_label |
github-actions
bot
added
the
Requires Wiki Update
DGamerL
approved these changes
Sep 19, 2024
Isn't this explicitly erasing british culture in favor of the american spelling? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Rectifies all (except one) spelling of Saber from "Sabre" in the code. The only non-changed thing is the .ogg that griefsky uses because to be honest I'm afraid to touch it, that's the whole reason.
Specifically fixes name of Captain's Saber (the recently reimagined rapier) and the Saber SMG.
Why It's Good For The Game
All other energy sabers are spelled correctly, "sabre" is the British spelling, we should be consistent and use saber.
Testing
It built, it launched, all the bloody in-hands were invisible because I forgot to change the icon names in the .dmi's.
So I went and fixed that, it launched, it worked, all sprites were visible, checked the item names and descs, checked the steal objective, made sure the Saber SMG was fine too.
Declaration
I do not believe this would need pre-approval.
Changelog
🆑
spellcheck: All instances of "sabre" are now correctly spelled as "saber".
/:cl: