-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TGUI Color Picker #26326
TGUI Color Picker #26326
Conversation
Hi, as explained in #26085, on discord here and on the top of the repo home page here. We are currently in a period of "quality releases" where only refactor or fix PRs are permitted unless you have prior approval for another PR type. This is commonly referred to as a feature freeze. As such, this PR is going to be closed. You are welcome to revisit the idea once the freeze has been lifted, but we encourage all contributors to get stuck in with fixes for items on the issue list! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the impression that this has not been properly tested
Here's a small review of what should be done first of all, add a if(isnull(value)) return
check after input where it doesn't exist, secondly replace if(value) ...
and if(!value) return
with the aforementioned isnull()
.
Since tgui inputs return null if the player decides to close the window or click Cancel
I hope you don't repeat my fate with a bunch of follow up PRs on fix checks
Co-authored-by: Contrabang <[email protected]> Signed-off-by: Spaghetti-bit <[email protected]>
623939d
to
b14682d
Compare
Signed-off-by: Spaghetti-bit <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a TM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Test merge has seen no issues at this time. All outstanding conversations have been resolved.
What Does This PR Do
Ports BeeStation/BeeStation-Hornet#9417 from Beestation.
TGUI Color wheel, converts most (if not all) color picker matrixes into TGUI Color pickers.
Why It's Good For The Game
It's nice on the eyes and is another step forward towards implementing TGUI fully.
Images of changes
Testing
Lots of different UI tests, character preferences, appearance changer / mirror, DNA powers like morph, machine monitor.
Changelog
🆑
tweak: Color Picker now uses TGUI
/:cl: